Skip empty embedded TA binaries during registration - #1197
Open
Praveen K Paladugu (praveen-pk) wants to merge 1 commit into
Open
Skip empty embedded TA binaries during registration#1197Praveen K Paladugu (praveen-pk) wants to merge 1 commit into
Praveen K Paladugu (praveen-pk) wants to merge 1 commit into
Conversation
Avoid panicking during initialization when an embedded TA binary is an empty placeholder. Fixes: e33f6ff: share TA binaries through a global UUID map Signed-off-by: Praveen K Paladugu <prapal@linux.microsoft.com>
Contributor
Author
|
Without this fix LiteBox panics at: |
Sangho Lee (sangho2)
approved these changes
Aug 18, 2026
Sangho Lee (sangho2)
left a comment
Sangho Lee (sangho2)
left a comment
Contributor
There was a problem hiding this comment.
LGTM. I left a comment.
| for ta_binary in TA_BINARIES { | ||
| assert!(register_embedded_ta(shim, ta_binary)); | ||
| if !ta_binary.is_empty() { | ||
| assert!(register_embedded_ta(shim, ta_binary)); |
Contributor
There was a problem hiding this comment.
If an empty placeholder is legitimate, we might not need assert, or debug_assert might be better.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid panicking during initialization when an embedded TA binary is an empty placeholder.
Fixes: e33f6ff: share TA binaries through a global UUID map