Skip to content

Skip empty embedded TA binaries during registration #1197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Praveen K Paladugu (praveen-pk) wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −1
Open

Skip empty embedded TA binaries during registration #1197

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion litebox_runner_lvbs/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1355,7 +1355,9 @@ fn register_embedded_ta(shim: &litebox_shim_optee::OpteeShim, ta_binary: &'stati
/// Register all TA binaries embedded in the runner image.
fn register_embedded_tas(shim: &litebox_shim_optee::OpteeShim) {
for ta_binary in TA_BINARIES {
assert!(register_embedded_ta(shim, ta_binary));
if !ta_binary.is_empty() {
assert!(register_embedded_ta(shim, ta_binary));

@sangho2 Sangho Lee (sangho2) Aug 18, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If an empty placeholder is legitimate, we might not need assert, or debug_assert might be better.

}
}
}

Expand Down