fix(client): default resultSchema to CallToolResultSchema in getTaskResult (#2742) - #2759
Open
amasen02 wants to merge 3 commits into
Open
Conversation
🦋 Changeset detectedLatest commit: 4319dc7 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2742
client.experimental.tasks.getTaskResult(taskId)declaredresultSchema?: T, but when omitted,undefinedwas forwarded to the underlying protocol request, causingTypeError: Cannot read properties of undefined (reading '_zod')inisZ4Schemaduring response validation.This change:
resultSchematoCallToolResultSchemaboth at runtime and in type generics forExperimentalClientTasks.getTaskResult, matching the convention used bycallToolStream().getTaskResult(taskId)works when omittingresultSchema(using default) as well as when supplying an explicit schema.Motivation and Context
Resolves #2742. Callers omitting the optional schema parameter previously experienced an uncaught runtime error in the transport handler. Defaulting to
CallToolResultSchemaprovides the expected behavior.How Has This Been Tested?
TypeError: Cannot read properties of undefined (reading '_zod')before fix when omittingresultSchema.npx vitest run test/client/index.test.ts -t "getTaskResult"— passed.test/experimental/tasks— 100% passed.npx tsc --noEmit— clean with zero errors.