Skip to content

fix(client): default resultSchema to CallToolResultSchema in getTaskResult (#2742) #2759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
amasen02 wants to merge 3 commits into
base: v1.x
Choose a base branch
from
+16 −5
Open

fix(client): default resultSchema to CallToolResultSchema in getTaskResult (#2742) #2759

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
511855a
fix(client): default resultSchema to CallToolResultSchema in getTaskR…
amasen02 Sep 5, 2026
d197f01
chore: add changeset for getTaskResult default schema
amasen02 Sep 5, 2026
4319dc7
style: format changeset file with prettier
amasen02 Sep 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/default-get-task-result-schema.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@modelcontextprotocol/sdk': patch
---

Default `resultSchema` to `CallToolResultSchema` in `ExperimentalClientTasks.getTaskResult`
6 changes: 4 additions & 2 deletions src/experimental/tasks/client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,13 +178,15 @@ export class ExperimentalClientTasks<
* Retrieves the result of a completed task.
*
* @param taskId - The task identifier
* @param resultSchema - Zod schema for validating the result
* @param resultSchema - Zod schema for validating the result (defaults to CallToolResultSchema)
* @param options - Optional request options
* @returns The task result
*
* @experimental
*/
async getTaskResult<T extends AnyObjectSchema>(taskId: string, resultSchema?: T, options?: RequestOptions): Promise<SchemaOutput<T>> {
async getTaskResult<
T extends typeof CallToolResultSchema | typeof CompatibilityCallToolResultSchema | AnyObjectSchema = typeof CallToolResultSchema
>(taskId: string, resultSchema: T = CallToolResultSchema as T, options?: RequestOptions): Promise<SchemaOutput<T>> {
// Delegate to the client's underlying Protocol method
return (
this._client as unknown as {
Expand Down
10 changes: 7 additions & 3 deletions test/client/index.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2576,9 +2576,13 @@ describe('Task-based execution', () => {

expect(taskId).toBeDefined();

// Query task result using the captured task ID
const result = await client.experimental.tasks.getTaskResult(taskId!, CallToolResultSchema);
expect(result.content).toEqual([{ type: 'text', text: 'Result data!' }]);
// Query task result using the captured task ID with default schema
const defaultResult = await client.experimental.tasks.getTaskResult(taskId!);
expect(defaultResult.content).toEqual([{ type: 'text', text: 'Result data!' }]);

// Query task result with explicit schema
const explicitResult = await client.experimental.tasks.getTaskResult(taskId!, CallToolResultSchema);
expect(explicitResult.content).toEqual([{ type: 'text', text: 'Result data!' }]);
});

test('should query task list from server using listTasks', async () => {
Expand Down
Loading