Fix update-dependent-repositories-gomod toolchain pin - #203
Merged
Conversation
The bot workflow that updates sdk after a merge to main was pinned to go-version 1.23.3, which fails now that grpc v1.82.1 (merged in #202) requires go >= 1.25.0: go: go.mod requires go >= 1.24.0 (running go 1.23.3; GOTOOLCHAIN=local) Bump the pin to 1.25.0 and set GOTOOLCHAIN=auto for the update step so future go directive bumps in dependent repos don't hard-fail the same way; Go will auto-download whatever toolchain the target module actually requires instead of refusing to proceed. Signed-off-by: Botond Szirtes <botond.szirtes@est.tech>
bszirtes
added a commit
to networkservicemesh/.github
that referenced
this pull request
Aug 24, 2026
Dependent repos (sdk-k8s, sdk-kernel, cmd-nsmgr, etc.) will require go >= 1.25.0 once they pull in the current sdk/api uplift (grpc v1.82.1). The bot's setup-go step was pinned to 1.23.3, which fails with: go: go.mod requires go >= 1.25.0 (running go 1.23.3; GOTOOLCHAIN=local) when it runs 'go get -u .../sdk@main' + 'go mod tidy' inside each dependent repo checkout. Bump the pin to 1.25.0 and set GOTOOLCHAIN=auto for the update step so future go directive bumps in any dependent repo don't hard-fail the same way. This mirrors the same fix already applied directly in the api repo's own copy of this workflow (networkservicemesh/api#203). This is a shared @main-referenced workflow, so it takes effect immediately for every consumer (api, sdk, and their dependents) once merged. Signed-off-by: Botond Szirtes <botond.szirtes@est.tech>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
After #202 merged (grpc uplift to v1.82.1, which requires go >= 1.25.0),
the
update-dependent-repositories-gomodworkflow failed when tryingto update
sdk:The workflow's
actions/setup-gostep was pinned to1.23.3, andwithout
GOTOOLCHAIN=autoit refuses to self-upgrade even though anewer toolchain is available.
Fix
setup-gopin to1.25.0GOTOOLCHAIN=autofor the update step, so futuregodirectivebumps in dependent repos (
sdkand others in the matrix) don't hard-failthe same way — Go will download whatever toolchain the target module
actually needs.
This only touches this repo's own bot workflow; no module/dependency
changes.