chore: Undeprecated ISecureRandom - #63412
Open
CarlSchwan wants to merge 1 commit into
Open
Conversation
- This makes it easy to mock randomness in unit tests as ISecureRandom is a service. - The default list of character would then need to be copied everywhere - This is used all other the place Signed-off-by: Carl Schwan <carl@carlschwan.eu>
CarlSchwan
requested review from
Altahrim,
icewind1991,
leftybournes and
sorbaugh
and removed request for
a team
August 19, 2026 12:11
nickvergessen
approved these changes
Aug 19, 2026
susnux
approved these changes
Aug 19, 2026
| * @since 8.0.0 | ||
| * @deprecated 35.0.0 Use {@see Randomizer::getBytesFromString()} available in PHP 8.3+ instead. | ||
| */ | ||
| public function generate(int $length, |
Contributor
There was a problem hiding this comment.
instead this could just make use of the randomizer (if it is not already doing it)
susnux
added
3. to review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
See also comment from @nickvergessen #61538 (comment)
TODO
Checklist
3. to review, feature component)stable32)AI (if applicable)