Skip to content

chore: Undeprecated ISecureRandom #63412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
CarlSchwan wants to merge 1 commit into
base: master
Choose a base branch
from
+0 −125
Open

chore: Undeprecated ISecureRandom #63412

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
124 changes: 0 additions & 124 deletions build/psalm-baseline.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,11 +28,6 @@
<code><![CDATA[getFederationIdFromSharedSecret]]></code>
</DeprecatedMethod>
</file>
<file src="apps/cloud_federation_api/lib/Controller/TokenController.php">
<DeprecatedMethod>
<code><![CDATA[generate]]></code>
</DeprecatedMethod>
</file>
<file src="apps/comments/lib/Activity/Listener.php">
<DeprecatedConstant>
<code><![CDATA[CommentsEvent::EVENT_ADD]]></code>
Expand Down Expand Up @@ -190,7 +185,6 @@
</file>
<file src="apps/dav/lib/CalDAV/CalDavBackend.php">
<DeprecatedMethod>
<code><![CDATA[generate]]></code>
<code><![CDATA[getAppValue]]></code>
<code><![CDATA[getAppValue]]></code>
</DeprecatedMethod>
Expand Down Expand Up @@ -275,11 +269,6 @@
<code><![CDATA[$this->baseEvent->DTSTART]]></code>
</UndefinedMagicPropertyFetch>
</file>
<file src="apps/dav/lib/CalDAV/Federation/FederationSharingService.php">
<DeprecatedMethod>
<code><![CDATA[generate]]></code>
</DeprecatedMethod>
</file>
<file src="apps/dav/lib/CalDAV/ICSExportPlugin/ICSExportPlugin.php">
<DeprecatedMethod>
<code><![CDATA[getAppValue]]></code>
Expand Down Expand Up @@ -454,9 +443,6 @@
</RedundantCondition>
</file>
<file src="apps/dav/lib/CalDAV/Schedule/IMipService.php">
<DeprecatedMethod>
<code><![CDATA[generate]]></code>
</DeprecatedMethod>
<UndefinedMagicPropertyFetch>
<code><![CDATA[$component->DTSTART]]></code>
<code><![CDATA[$component->UID]]></code>
Expand Down Expand Up @@ -878,11 +864,6 @@
<code><![CDATA[setAppValue]]></code>
</DeprecatedMethod>
</file>
<file src="apps/dav/lib/Controller/DirectController.php">
<DeprecatedMethod>
<code><![CDATA[generate]]></code>
</DeprecatedMethod>
</file>
<file src="apps/dav/lib/Controller/InvitationResponseController.php">
<UndefinedMagicPropertyFetch>
<code><![CDATA[$vObject->{'VEVENT'}]]></code>
Expand Down Expand Up @@ -1016,11 +997,6 @@
<code><![CDATA[setAppValue]]></code>
</DeprecatedMethod>
</file>
<file src="apps/dav/lib/Paginate/PaginateCache.php">
<DeprecatedMethod>
<code><![CDATA[generate]]></code>
</DeprecatedMethod>
</file>
<file src="apps/dav/lib/Search/ACalendarSearchProvider.php">
<UndefinedMagicPropertyFetch>
<code><![CDATA[$component->{'RECURRENCE-ID'}]]></code>
Expand Down Expand Up @@ -1079,9 +1055,6 @@
</UndefinedMagicPropertyFetch>
</file>
<file src="apps/dav/lib/Service/ExampleEventService.php">
<DeprecatedMethod>
<code><![CDATA[generate]]></code>
</DeprecatedMethod>
<UndefinedMagicPropertyAssignment>
<code><![CDATA[$vEvent->DTEND]]></code>
<code><![CDATA[$vEvent->DTSTART]]></code>
Expand Down Expand Up @@ -1262,9 +1235,6 @@
</TypeDoesNotContainType>
</file>
<file src="apps/encryption/lib/Crypto/EncryptAll.php">
<DeprecatedMethod>
<code><![CDATA[generate]]></code>
</DeprecatedMethod>
<InternalMethod>
<code><![CDATA[copy]]></code>
<code><![CDATA[file_exists]]></code>
Expand Down Expand Up @@ -1351,7 +1321,6 @@
</file>
<file src="apps/federatedfilesharing/lib/FederatedShareProvider.php">
<DeprecatedMethod>
<code><![CDATA[generate]]></code>
<code><![CDATA[getAppValue]]></code>
<code><![CDATA[getAppValue]]></code>
<code><![CDATA[getAppValue]]></code>
Expand Down Expand Up @@ -1386,16 +1355,6 @@
<code><![CDATA[sendNotification]]></code>
</DeprecatedMethod>
</file>
<file src="apps/federatedfilesharing/lib/TokenHandler.php">
<DeprecatedMethod>
<code><![CDATA[generate]]></code>
</DeprecatedMethod>
</file>
<file src="apps/federation/lib/Controller/OCSAuthAPIController.php">
<DeprecatedMethod>
<code><![CDATA[generate]]></code>
</DeprecatedMethod>
</file>
<file src="apps/federation/lib/DbHandler.php">
<LessSpecificReturnStatement>
<code><![CDATA[$result]]></code>
Expand All @@ -1404,11 +1363,6 @@
<code><![CDATA[list<array{id: int, url: string, url_hash: string, shared_secret: ?string, status: int, sync_token: ?string}>]]></code>
</MoreSpecificReturnType>
</file>
<file src="apps/federation/lib/TrustedServers.php">
<DeprecatedMethod>
<code><![CDATA[generate]]></code>
</DeprecatedMethod>
</file>
<file src="apps/files/lib/Activity/Provider.php">
<FalsableReturnStatement>
<code><![CDATA[$this->fileEncrypted[$fileId]]]></code>
Expand Down Expand Up @@ -1475,11 +1429,6 @@
<code><![CDATA[getTemplates]]></code>
</UndefinedInterfaceMethod>
</file>
<file src="apps/files/lib/Controller/OpenLocalEditorController.php">
<DeprecatedMethod>
<code><![CDATA[generate]]></code>
</DeprecatedMethod>
</file>
<file src="apps/files/lib/Controller/ViewController.php">
<DeprecatedMethod>
<code><![CDATA[getUserValue]]></code>
Expand Down Expand Up @@ -1620,11 +1569,6 @@
<code><![CDATA[registerBackends]]></code>
</DeprecatedMethod>
</file>
<file src="apps/files_external/lib/Service/EncryptionService.php">
<DeprecatedMethod>
<code><![CDATA[generate]]></code>
</DeprecatedMethod>
</file>
<file src="apps/files_external/lib/Service/StoragesService.php">
<DeprecatedMethod>
<code><![CDATA[Util::emitHook(
Expand Down Expand Up @@ -1704,7 +1648,6 @@
<code><![CDATA[emitAccessShareHook]]></code>
<code><![CDATA[emitAccessShareHook]]></code>
<code><![CDATA[emitAccessShareHook]]></code>
<code><![CDATA[generate]]></code>
</DeprecatedMethod>
</file>
<file src="apps/files_sharing/lib/External/Manager.php">
Expand Down Expand Up @@ -2260,12 +2203,6 @@
</DeprecatedConstant>
<DeprecatedMethod>
<code><![CDATA[deleteUserValue]]></code>
<code><![CDATA[generate]]></code>
<code><![CDATA[generate]]></code>
<code><![CDATA[generate]]></code>
<code><![CDATA[generate]]></code>
<code><![CDATA[generate]]></code>
<code><![CDATA[generate]]></code>
<code><![CDATA[getAppValue]]></code>
<code><![CDATA[getAppValue]]></code>
<code><![CDATA[getUserValue]]></code>
Expand All @@ -2289,11 +2226,6 @@
<code><![CDATA[IAccountManager::PROPERTY_TWITTER]]></code>
</DeprecatedConstant>
</file>
<file src="apps/settings/lib/Controller/AuthSettingsController.php">
<DeprecatedMethod>
<code><![CDATA[generate]]></code>
</DeprecatedMethod>
</file>
<file src="apps/settings/lib/Controller/MailSettingsController.php">
<DeprecatedMethod>
<code><![CDATA[getUserValue]]></code>
Expand Down Expand Up @@ -2333,7 +2265,6 @@
</file>
<file src="apps/settings/lib/Mailer/NewUserMailHelper.php">
<DeprecatedMethod>
<code><![CDATA[generate]]></code>
<code><![CDATA[setUserValue]]></code>
</DeprecatedMethod>
</file>
Expand Down Expand Up @@ -2437,23 +2368,12 @@
<code><![CDATA[getAppValue]]></code>
</DeprecatedMethod>
</file>
<file src="apps/settings/lib/SetupChecks/RandomnessSecure.php">
<DeprecatedMethod>
<code><![CDATA[generate]]></code>
</DeprecatedMethod>
</file>
<file src="apps/sharebymail/lib/Settings/SettingsManager.php">
<DeprecatedMethod>
<code><![CDATA[getAppValue]]></code>
<code><![CDATA[getAppValue]]></code>
</DeprecatedMethod>
</file>
<file src="apps/sharebymail/lib/ShareByMailProvider.php">
<DeprecatedMethod>
<code><![CDATA[generate]]></code>
<code><![CDATA[generate]]></code>
</DeprecatedMethod>
</file>
<file src="apps/testing/lib/AlternativeHomeUserBackend.php">
<DeprecatedInterface>
<code><![CDATA[AlternativeHomeUserBackend]]></code>
Expand Down Expand Up @@ -2641,16 +2561,6 @@
<code><![CDATA[$svg]]></code>
</NullableReturnStatement>
</file>
<file src="apps/twofactor_backupcodes/lib/Service/BackupCodeStorage.php">
<DeprecatedMethod>
<code><![CDATA[generate]]></code>
</DeprecatedMethod>
</file>
<file src="apps/updatenotification/lib/Controller/AdminController.php">
<DeprecatedMethod>
<code><![CDATA[generate]]></code>
</DeprecatedMethod>
</file>
<file src="apps/user_ldap/lib/Access.php">
<DeprecatedMethod>
<code><![CDATA[emit]]></code>
Expand Down Expand Up @@ -2836,11 +2746,6 @@
<code><![CDATA[is_array($value) ? json_encode($value) : $value]]></code>
</FalsableReturnStatement>
</file>
<file src="apps/webhook_listeners/lib/Service/TokenService.php">
<DeprecatedMethod>
<code><![CDATA[generate]]></code>
</DeprecatedMethod>
</file>
<file src="apps/workflowengine/lib/AppInfo/Application.php">
<RedundantCondition>
<code><![CDATA[$event instanceof Event]]></code>
Expand Down Expand Up @@ -3005,19 +2910,11 @@
<code><![CDATA[listen]]></code>
</DeprecatedMethod>
</file>
<file src="core/Command/User/Add.php">
<DeprecatedMethod>
<code><![CDATA[generate]]></code>
</DeprecatedMethod>
</file>
<file src="core/Command/User/AuthTokens/Add.php">
<DeprecatedClass>
<code><![CDATA[IToken::DO_NOT_REMEMBER]]></code>
<code><![CDATA[IToken::PERMANENT_TOKEN]]></code>
</DeprecatedClass>
<DeprecatedMethod>
<code><![CDATA[generate]]></code>
</DeprecatedMethod>
</file>
<file src="core/Command/User/AuthTokens/ListCommand.php">
<DeprecatedClass>
Expand Down Expand Up @@ -3054,23 +2951,8 @@
<code><![CDATA[IToken::DO_NOT_REMEMBER]]></code>
<code><![CDATA[IToken::PERMANENT_TOKEN]]></code>
</DeprecatedClass>
<DeprecatedMethod>
<code><![CDATA[generate]]></code>
<code><![CDATA[generate]]></code>
<code><![CDATA[generate]]></code>
</DeprecatedMethod>
</file>
<file src="core/Controller/ClientFlowLoginController.php">
<DeprecatedMethod>
<code><![CDATA[generate]]></code>
<code><![CDATA[generate]]></code>
<code><![CDATA[generate]]></code>
</DeprecatedMethod>
</file>
<file src="core/Controller/ClientFlowLoginV2Controller.php">
<DeprecatedMethod>
<code><![CDATA[generate]]></code>
</DeprecatedMethod>
<TypeDoesNotContainType>
<code><![CDATA[!is_string($stateToken)]]></code>
</TypeDoesNotContainType>
Expand Down Expand Up @@ -3219,11 +3101,6 @@
<code><![CDATA[IToken::DO_NOT_REMEMBER]]></code>
<code><![CDATA[IToken::PERMANENT_TOKEN]]></code>
</DeprecatedClass>
<DeprecatedMethod>
<code><![CDATA[generate]]></code>
<code><![CDATA[generate]]></code>
<code><![CDATA[generate]]></code>
</DeprecatedMethod>
</file>
<file src="core/Sharing/Recipient/TeamShareRecipientType.php">
<ImplementedParamTypeMismatch>
Expand Down Expand Up @@ -4217,7 +4094,6 @@
<file src="tests/lib/TestCase.php">
<DeprecatedMethod>
<code><![CDATA[$container]]></code>
<code><![CDATA[generate]]></code>
</DeprecatedMethod>
<InternalMethod>
<code><![CDATA[lockFile]]></code>
Expand Down
1 change: 0 additions & 1 deletion lib/public/Security/ISecureRandom.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,6 @@ interface ISecureRandom {
* specified all valid base64 characters are used.
* @return string
* @since 8.0.0
* @deprecated 35.0.0 Use {@see Randomizer::getBytesFromString()} available in PHP 8.3+ instead.
*/
public function generate(int $length,

@susnux susnux Aug 19, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead this could just make use of the randomizer (if it is not already doing it)

string $characters = 'ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789+/'): string;
Expand Down
Loading