test(engine): cover missing dynamic-run programs - #16244
Merged
Merged
Conversation
Add a dynamic-run action whose executable cannot be resolved. The expected assertion records the current internal failure so a subsequent fix can update it to the standard program-not-found diagnostic. Signed-off-by: Rudi Grinberg <me@rgrinberg.com>
rgrinberg
added a commit
that referenced
this pull request
Aug 29, 2026
Represent an unresolved `dynamic-run` program by its requested filename when encoding the dynamic action, while retaining the structured lookup error for execution. Missing programs now produce the normal location-aware program-not-found diagnostic instead of an assertion failure. The regression is covered by #16244. Signed-off-by: Rudi Grinberg <me@rgrinberg.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A missing executable in
dynamic-runcurrently reaches an assertion whileencoding the action instead of producing the usual program-not-found diagnostic.
Record that behavior in the action-plugin cram suite. A follow-up change will
replace the assertion and update the expectation.