test(engine): cover duplicate action locks - #16247
Merged
Merged
Conversation
Add a rule that declares the same lock twice and snapshot its timeout instead of the requested target. Acquiring the same non-reentrant mutex twice demonstrates the self-deadlock fixed by the following change. Signed-off-by: Rudi Grinberg <me@rgrinberg.com>
rgrinberg
added a commit
that referenced
this pull request
Aug 29, 2026
Canonicalize action lock paths as a set when constructing and combining action properties. Duplicate declarations can no longer make a rule acquire the same non-reentrant mutex twice, and digesting and acquisition consume the same canonical ordering without repeated sorting. The regression is covered by #16247.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A rule that declares the same lock twice currently tries to acquire the same
non-reentrant mutex twice and deadlocks.
Add a cram regression that snapshots the timeout instead of the requested
target. A follow-up change will deduplicate lock acquisition.