Skip to content

test(engine): cover duplicate action locks #16247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rgrinberg merged 1 commit into from
Aug 29, 2026
+17 −0
Merged

test(engine): cover duplicate action locks #16247

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions test/blackbox-tests/test-cases/tests-locks.t/run.t
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,3 +7,20 @@ These tests are run without locks. They should end together (= expected)
$ dune build --root=. -j 2 --diff-command=diff @all-tests-nolocks 2>&1 |
> grep "^> *" | uniq -c | [ $(wc -l) -eq 1 ] && echo '=' || echo '<>'
=

Duplicate lock declarations currently deadlock a rule by making it acquire the same
non-reentrant mutex twice.

$ mkdir duplicate-lock
$ cat >duplicate-lock/dune <<EOF
> (rule
> (target done)
> (locks same same)
> (action (write-file done done)))
> EOF
$ if $timeout 2 dune build --root=. duplicate-lock/done >/dev/null 2>&1; then
> cat _build/default/duplicate-lock/done
> else
> echo timed-out
> fi
timed-out
Loading