test(engine): cover failed action trace collection - #16249
Merged
Conversation
Have a failing action emit a valid trace event and snapshot the collected action traces afterward. The missing event records that result validation skips trace collection on action failure. Signed-off-by: Rudi Grinberg <me@rgrinberg.com>
rgrinberg
added a commit
that referenced
this pull request
Aug 29, 2026
Collect action-provided trace events even when result validation reports that the action failed. Validation and trace collection now run in sibling fibers, so neither can prevent the other from completing and both errors remain reportable. The regression is covered by #16249. Signed-off-by: Rudi Grinberg <me@rgrinberg.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a regression showing that action trace collection is skipped when result
validation raises for a failed action. The failure branch displays only events
supplied by actions with
dune trace cat --only-actions; its empty snapshotrecords the current behavior for a follow-up fix.