CONSOLE-5234: Remove Cypress CI entrypoint and test runner scripts - #16882
CONSOLE-5234: Remove Cypress CI entrypoint and test runner scripts#16882shahsahil264 wants to merge 1 commit into
Conversation
The Cypress E2E CI pipeline is being replaced by Playwright. Remove the Cypress-specific Prow entrypoint and test runner scripts that are no longer needed now that the Playwright equivalents are in place. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
Pipeline controller notification For optional jobs, comment This repository is configured in: LGTM mode |
|
@shahsahil264: This pull request references CONSOLE-5234 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: shahsahil264 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: openshift/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (4)
💤 Files with no reviewable changes (3)
WalkthroughThe PR removes the Cypress integration and Prow E2E shell scripts, while updating comments in the Playwright E2E script to clarify its responsibilities, execution location, and environment variables. ChangesE2E script updates
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested labels: 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
/pipeline required |
|
Scheduling tests matching the |
|
/hold until all Cypress tests are removed @shahsahil264, thanks for this! I think these changes really belong to https://redhat.atlassian.net/browse/CONSOLE-5232, and this PR should also include the additional changes documented there. I believe https://redhat.atlassian.net/browse/CONSOLE-5234 is to remove the Cypress CI jobs from the release repo. |
|
@shahsahil264: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Thanks @rhamilto, that makes sense! Closing this PR. All these changes (CI script removal + full Cypress cleanup) are combined in #16883 under CONSOLE-5232. CONSOLE-5234 will be a separate PR to the |
Analysis / Root cause:
The Cypress E2E CI pipeline is being replaced by Playwright (CONSOLE-5234). The Playwright CI entrypoint (
test-prow-playwright-e2e.sh) and test runner (test-playwright-e2e.sh) are already in place and functional. The Cypress equivalents are no longer needed.Solution description:
Remove the Cypress-specific Prow entrypoint and test runner scripts:
test-prow-e2e.sh— Prow CI entrypoint that routed totest-cypress.shfor scenarios (e2e, nightly-cypress, login, olmFull, dev-console, pipelines)test-prow-e2e-techpreview.sh— Empty stub (3 lines, no test invocations)frontend/integration-tests/test-cypress.sh— Cypress test runner handling package selection, headless mode, nightly suites, and mochawesome reportingAlso cleaned up stale comments in
test-prow-playwright-e2e.shthat referenced the now-deletedtest-prow-e2e.sh.The Playwright equivalents are unchanged:
test-prow-playwright-e2e.sh— Prow entrypoint for Playwright E2Etest-prow-playwright-e2e-techpreview.sh— Playwright techpreview stubfrontend/integration-tests/test-playwright-e2e.sh— Playwright test runnerNote: The corresponding CI job definitions in
openshift/release(removinge2e-gcp-consoleand promotinge2e-playwright) will be handled in a separate PR to that repo. The full Cypress codebase cleanup (test files, dependencies, docs) is tracked under CONSOLE-5232.Screenshots / screen recording:
N/A — CI infrastructure change, no UI impact.
Test setup:
No special setup required. The Playwright CI pipeline is already functional.
Test cases:
test-prow-playwright-e2e.shstill exists and is unchanged (except comment cleanup)frontend/integration-tests/test-playwright-e2e.shstill exists and is unchangedgrep -rn "test-prow-e2e\b" --include="*.sh"returns no results in CI scriptsBrowser conformance:
N/A — No UI changes.
Additional info:
This is part of the Cypress-to-Playwright migration effort. Related JIRAs:
Summary by CodeRabbit