Skip to content

CONSOLE-5234: Remove Cypress CI entrypoint and test runner scripts - #16882

Closed
shahsahil264 wants to merge 1 commit into
openshift:mainfrom
shahsahil264:CONSOLE-5234
Closed

CONSOLE-5234: Remove Cypress CI entrypoint and test runner scripts#16882
shahsahil264 wants to merge 1 commit into
openshift:mainfrom
shahsahil264:CONSOLE-5234

Conversation

@shahsahil264

@shahsahil264 shahsahil264 commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Analysis / Root cause:

The Cypress E2E CI pipeline is being replaced by Playwright (CONSOLE-5234). The Playwright CI entrypoint (test-prow-playwright-e2e.sh) and test runner (test-playwright-e2e.sh) are already in place and functional. The Cypress equivalents are no longer needed.

Solution description:

Remove the Cypress-specific Prow entrypoint and test runner scripts:

  • test-prow-e2e.sh — Prow CI entrypoint that routed to test-cypress.sh for scenarios (e2e, nightly-cypress, login, olmFull, dev-console, pipelines)
  • test-prow-e2e-techpreview.sh — Empty stub (3 lines, no test invocations)
  • frontend/integration-tests/test-cypress.sh — Cypress test runner handling package selection, headless mode, nightly suites, and mochawesome reporting

Also cleaned up stale comments in test-prow-playwright-e2e.sh that referenced the now-deleted test-prow-e2e.sh.

The Playwright equivalents are unchanged:

  • test-prow-playwright-e2e.sh — Prow entrypoint for Playwright E2E
  • test-prow-playwright-e2e-techpreview.sh — Playwright techpreview stub
  • frontend/integration-tests/test-playwright-e2e.sh — Playwright test runner

Note: The corresponding CI job definitions in openshift/release (removing e2e-gcp-console and promoting e2e-playwright) will be handled in a separate PR to that repo. The full Cypress codebase cleanup (test files, dependencies, docs) is tracked under CONSOLE-5232.

Screenshots / screen recording:

N/A — CI infrastructure change, no UI impact.

Test setup:

No special setup required. The Playwright CI pipeline is already functional.

Test cases:

  • Verify test-prow-playwright-e2e.sh still exists and is unchanged (except comment cleanup)
  • Verify frontend/integration-tests/test-playwright-e2e.sh still exists and is unchanged
  • grep -rn "test-prow-e2e\b" --include="*.sh" returns no results in CI scripts
  • No source code imports reference the deleted files

Browser conformance:

N/A — No UI changes.

Additional info:

This is part of the Cypress-to-Playwright migration effort. Related JIRAs:

Summary by CodeRabbit

  • Chores
    • Removed legacy Cypress and end-to-end test runner scripts.
    • Updated comments describing Playwright end-to-end test execution and environment variables.
    • Existing Playwright test behavior remains unchanged.

The Cypress E2E CI pipeline is being replaced by Playwright. Remove the
Cypress-specific Prow entrypoint and test runner scripts that are no
longer needed now that the Playwright equivalents are in place.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 29, 2026
@openshift-ci-robot

openshift-ci-robot commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

@shahsahil264: This pull request references CONSOLE-5234 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Analysis / Root cause:

The Cypress E2E CI pipeline is being replaced by Playwright (CONSOLE-5234). The Playwright CI entrypoint (test-prow-playwright-e2e.sh) and test runner (test-playwright-e2e.sh) are already in place and functional. The Cypress equivalents are no longer needed.

Solution description:

Remove the Cypress-specific Prow entrypoint and test runner scripts:

  • test-prow-e2e.sh — Prow CI entrypoint that routed to test-cypress.sh for scenarios (e2e, nightly-cypress, login, olmFull, dev-console, pipelines)
  • test-prow-e2e-techpreview.sh — Empty stub (3 lines, no test invocations)
  • frontend/integration-tests/test-cypress.sh — Cypress test runner handling package selection, headless mode, nightly suites, and mochawesome reporting

Also cleaned up stale comments in test-prow-playwright-e2e.sh that referenced the now-deleted test-prow-e2e.sh.

The Playwright equivalents are unchanged:

  • test-prow-playwright-e2e.sh — Prow entrypoint for Playwright E2E
  • test-prow-playwright-e2e-techpreview.sh — Playwright techpreview stub
  • frontend/integration-tests/test-playwright-e2e.sh — Playwright test runner

Note: The corresponding CI job definitions in openshift/release (removing e2e-gcp-console and promoting e2e-playwright) will be handled in a separate PR to that repo. The full Cypress codebase cleanup (test files, dependencies, docs) is tracked under CONSOLE-5232.

Screenshots / screen recording:

N/A — CI infrastructure change, no UI impact.

Test setup:

No special setup required. The Playwright CI pipeline is already functional.

Test cases:

  • Verify test-prow-playwright-e2e.sh still exists and is unchanged (except comment cleanup)
  • Verify frontend/integration-tests/test-playwright-e2e.sh still exists and is unchanged
  • grep -rn "test-prow-e2e\b" --include="*.sh" returns no results in CI scripts
  • No source code imports reference the deleted files

Browser conformance:

N/A — No UI changes.

Additional info:

This is part of the Cypress-to-Playwright migration effort. Related JIRAs:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
openshift-ci Bot requested review from rhamilto and spadgett July 29, 2026 19:01
@openshift-ci

openshift-ci Bot commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: shahsahil264
Once this PR has been reviewed and has the lgtm label, please assign rhamilto for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai

coderabbitai Bot commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 6fb879b3-8256-418c-8637-138c77df2b4d

📥 Commits

Reviewing files that changed from the base of the PR and between e6cdc2c and bd09c29.

📒 Files selected for processing (4)
  • frontend/integration-tests/test-cypress.sh
  • test-prow-e2e-techpreview.sh
  • test-prow-e2e.sh
  • test-prow-playwright-e2e.sh
💤 Files with no reviewable changes (3)
  • test-prow-e2e-techpreview.sh
  • frontend/integration-tests/test-cypress.sh
  • test-prow-e2e.sh

Walkthrough

The PR removes the Cypress integration and Prow E2E shell scripts, while updating comments in the Playwright E2E script to clarify its responsibilities, execution location, and environment variables.

Changes

E2E script updates

Layer / File(s) Summary
Remove Cypress test orchestration and clarify Playwright documentation
frontend/integration-tests/test-cypress.sh, test-prow-e2e.sh, test-prow-e2e-techpreview.sh, test-prow-playwright-e2e.sh
The Cypress runner and Prow Cypress scripts are deleted. Playwright script comments are updated to describe setup, test execution, CSP checks, repository-root usage, and environment variables.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested labels: kind/cypress

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly matches the main change: removing Cypress CI entrypoint and runner scripts.
Description check ✅ Passed The description covers the required template sections and provides clear analysis, solution, testing, and context.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR changes only remove/edit shell CI scripts; no Ginkgo test titles were added or modified, so the stable-name check is not applicable.
Test Structure And Quality ✅ Passed No Ginkgo test code changed; the PR only deletes shell scripts and edits comments, so the test-quality criteria don’t apply.
Microshift Test Compatibility ✅ Passed PASS: PR only removes Cypress shell scripts and trims comments in Playwright entrypoints; no new Ginkgo e2e tests or MicroShift-sensitive APIs were added.
Single Node Openshift (Sno) Test Compatibility ✅ Passed No new Ginkgo e2e tests were added; the PR only deletes shell scripts and edits comments, so SNO-specific test review is not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed No deployment manifests, controllers, or scheduling logic were changed; the PR only removes Cypress shell scripts and tweaks comments in a Playwright entrypoint.
Ote Binary Stdout Contract ✅ Passed Only shell scripts were deleted/comment-updated; no Go main/suite code or stdout logging changes were introduced.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed No new Ginkgo e2e tests were added; the PR only deletes shell scripts and tweaks comments, with no IPv4 or external-connectivity logic.
No-Weak-Crypto ✅ Passed The PR only deletes Cypress scripts and tweaks comments; diff scans found no MD5/SHA1/DES/RC4/ECB or custom crypto/comparison code.
Container-Privileges ✅ Passed PASS: The PR only deletes shell scripts and edits comments; the patch contains no privileged/hostPID/hostNetwork/hostIPC/allowPrivilegeEscalation/SYS_ADMIN settings.
No-Sensitive-Data-In-Logs ✅ Passed Only comment cleanup and deletions; no new secret/PII logging added. Existing kubeadmin password handling remains wrapped by set +x/ set -x.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@shahsahil264

Copy link
Copy Markdown
Contributor Author

/pipeline required
/retest

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-gcp-console
/test e2e-playwright

@rhamilto

Copy link
Copy Markdown
Member

/hold until all Cypress tests are removed

@shahsahil264, thanks for this! I think these changes really belong to https://redhat.atlassian.net/browse/CONSOLE-5232, and this PR should also include the additional changes documented there. I believe https://redhat.atlassian.net/browse/CONSOLE-5234 is to remove the Cypress CI jobs from the release repo.

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 29, 2026
@openshift-ci

openshift-ci Bot commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

@shahsahil264: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/backend bd09c29 link true /test backend

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@shahsahil264

shahsahil264 commented Jul 29, 2026

Copy link
Copy Markdown
Contributor Author

Thanks @rhamilto, that makes sense! Closing this PR. All these changes (CI script removal + full Cypress cleanup) are combined in #16883 under CONSOLE-5232. CONSOLE-5234 will be a separate PR to the openshift/release repo to remove the CI job definitions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants