CONSOLE-5232: Remove all Cypress references from the codebase - #16883
Open
shahsahil264 wants to merge 4 commits into
Open
CONSOLE-5232: Remove all Cypress references from the codebase#16883shahsahil264 wants to merge 4 commits into
shahsahil264 wants to merge 4 commits into
Conversation
Contributor
|
Pipeline controller notification For optional jobs, comment This repository is configured in: LGTM mode |
openshift-ci-robot
added
the
jira/valid-reference
Contributor
|
@shahsahil264: This pull request references CONSOLE-5232 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Contributor
|
Important Review skippedToo many files! This PR contains 495 files, which is 195 over the limit of 300. To get a review, narrow the scope: ⚙️ Run configurationConfiguration used: Repository: openshift/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (495)
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: shahsahil264 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
openshift-ci
Bot
added
component/helm
logonoff
reviewed
Jul 29, 2026
Member
There was a problem hiding this comment.
I think let's move the playwright testing stuff to test-prow-e2e.sh and delete test-prow-playwright-e2e.sh (or turn that script into a noop until the job is removed)?
the e2e-gcp-console job is required but the playwright one is not, so this ensures the e2e job passing is still a merge requirement
the playwright distinction in the job name is also no longer necessary, e2e-gcp- is more descriptive in that sense
Contributor
Author
There was a problem hiding this comment.
Good call — done. test-prow-e2e.sh now runs Playwright and test-prow-playwright-e2e.sh is deleted. The openshift/release PR (CONSOLE-5234) will update e2e-gcp-console to use the console-playwright-runner image and remove the e2e-playwright / e2e-playwright-techpreview jobs.
Contributor
Author
|
/hold |
openshift-ci
Bot
added
the
do-not-merge/hold
logonoff
reviewed
Jul 29, 2026
The Cypress E2E CI pipeline is being replaced by Playwright. Remove the Cypress-specific Prow entrypoint and test runner scripts that are no longer needed now that the Playwright equivalents are in place. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Complete the Cypress-to-Playwright migration by removing all remaining Cypress test infrastructure: - Delete all integration-tests/ directories (7 packages: integration-tests, OLM, dev-console, helm-plugin, knative-plugin, topology, container-security) - Remove Cypress deps and scripts from frontend/package.json - Remove gherkin-lint from test-frontend.sh and package.json - Remove CYPRESS_INSTALL_BINARY=0 from Dockerfile - Remove Cypress system deps from Dockerfile.builder - Update README.md, TESTING.md, INTERNATIONALIZATION.md, AGENTS.md - Clean up .gitignore Cypress artifact patterns - Regenerate yarn.lock Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Move bad-pods.ts from deleted integration-tests/ to __tests__/ and update imports. Remove stale integration-tests references from jest.config.ts and knip.ts. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Address review feedback: - Move Playwright logic into test-prow-e2e.sh so the required e2e-gcp-console CI job runs Playwright directly - Delete test-prow-playwright-e2e.sh and test-prow-playwright-e2e-techpreview.sh - Recreate test-prow-e2e-techpreview.sh as empty stub - Remove unused esbuild-loader dependency Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
shahsahil264
force-pushed
the
CONSOLE-5232
branch
from
July 29, 2026 20:36
556f4db to
07e0221
Compare
Contributor
|
@shahsahil264: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Analysis / Root cause:
The Cypress-to-Playwright E2E migration is complete. All Cypress test infrastructure, CI scripts, dependencies, and documentation references need to be removed from the codebase (CONSOLE-5232).
Solution description:
Complete removal of all Cypress references from the codebase:
CI scripts removed:
test-prow-e2e.sh— Prow CI entrypoint for Cypress E2Etest-prow-e2e-techpreview.sh— empty stubfrontend/integration-tests/test-cypress.sh— Cypress test runnertest-prow-playwright-e2e.shTest infrastructure removed (7 directories, ~430 files):
frontend/packages/integration-tests/— 15.cy.tsfiles, cypress configs, support files (@console/cypress-integration-tests)frontend/packages/operator-lifecycle-manager/integration-tests/— 9.cy.tsfiles (@console/operator-lifecycle-manager-integration-tests)frontend/packages/dev-console/integration-tests/— 49.featurefiles, step definitions (@dev-console/integration-tests)frontend/packages/helm-plugin/integration-tests/— 11.featurefiles, step definitions (@helm-plugin/integration-tests)frontend/packages/knative-plugin/integration-tests/— 31.featurefiles, step definitions (@knative-plugin/integration-tests)frontend/packages/topology/integration-tests/— support/page-objects onlyfrontend/packages/container-security/integration-tests/— single test fixture file (relocated to__tests__/)Dependencies removed from
frontend/package.json:cypress,cypress-axe,cypress-cucumber-preprocessor,cypress-jest-adapter,cypress-multi-reporters,@cypress/webpack-preprocessor,gherkin-lintmocha-junit-reporter,mochawesome,mochawesome-merge,mochawesome-report-generator(Cypress reporting only)dependenciesMeta, workspace patterns forintegration-testsCI/build cleanup:
test-frontend.sh— removedyarn run gherkin-lintDockerfile— removedCYPRESS_INSTALL_BINARY=0Dockerfile.builder— removed Cypress system deps (libgtk, libgconf, etc.)Documentation updated:
README.md— replaced Cypress "Integration Tests" section with PlaywrightTESTING.md— updated to reference PlaywrightINTERNATIONALIZATION.md— updated testing referencesAGENTS.md— updated E2E tool and migration section.gitignore— removed Cypress artifact patternsBroken imports fixed:
bad-pods.tstest fixture from deletedcontainer-security/integration-tests/to__tests__/integration-testsreferences fromjest.config.tsandknip.tsNote: The corresponding CI job definitions in
openshift/release(removinge2e-gcp-consoleand promotinge2e-playwright) will be handled in a separate PR to that repo under CONSOLE-5234.Screenshots / screen recording:
N/A — infrastructure cleanup, no UI impact.
Test setup:
No special setup required.
Test cases:
yarn install— lockfile regenerates cleanly (verified)yarn test— 1786 passed, same as main branch (9 pre-existing failures, verified identical)grep -rn "cypress\|gherkin" --include="*.sh" --include="*.ts" --include="*.js" --include="*.md"— no project source references remain (onlynode_modules)integration-tests/directoriestest-prow-playwright-e2e.shandtest-playwright-e2e.shunchanged and functionalBrowser conformance:
N/A — No UI changes.
Additional info:
Related JIRAs:
openshift/release(separate PR)