[release-4.22]AGENT-1548: Backport NoRegistryClusterInstall feature to release-4.22 - #6323
[release-4.22]AGENT-1548: Backport NoRegistryClusterInstall feature to release-4.22#6323bfournie wants to merge 14 commits into
Conversation
AGENT-1449: Add IRI registry authentication support to MCO
AGENT-1443: IRI Add certificate regeneration to MCS cert rotation controller
AGENT-1514: Add ML-KEM verification test for IRI registry
…-service AGENT-1517: disable iri-registry service on IRI delete
AGENT-1517: fix iri deletion test
AGENT-1491: reclaim disk space from the node when IRI resource is deleted
AGENT-1488: Aggregate IRI status from MachineConfigNodes
OCPBUGS-86671: Fix InternalReleaseImage URL transform
…-auth AGENT-1526: disable htpasswd auth on IRI registry, keep read-only
…domain AGENT-1531: Remove localhost.localdomain workaround for MCN IRI image field
…ests AGENT-1517: avoid running IRI deletion tests for standard e2e IRI tests
AGENT-1517: move helpers in iri e2e main test
|
Pipeline controller notification For optional jobs, comment This repository is configured in: LGTM mode |
|
@bfournie: This pull request references AGENT-1500 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: openshift/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
@bfournie: This pull request references AGENT-1548 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
|
@bfournie: This pull request references AGENT-1548 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/test unit |
|
/test unit |
|
/test unit |
1 similar comment
|
/test unit |
|
/test ? |
|
/test e2e-agent-compact-ipv4-iso-no-registry |
1 similar comment
|
/test e2e-agent-compact-ipv4-iso-no-registry |
|
Scheduling tests matching the |
|
/retitle [release-4.22]AGENT-1548: Backport NoRegistryClusterInstall feature to release-4.22 |
|
/retest-required |
yuqi-zhang
left a comment
There was a problem hiding this comment.
Logically seems fine - I think this is only "missing" #6119 - would probably be nice to have.
If both core MCO tests are fine, and it's passing your install job, this should be safe to merge
NO-ISSUE: Lower IRI deletion log verbosity
|
/lgtm |
|
Scheduling tests matching the |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andfasano, bfournie, yuqi-zhang The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Good idea, added #6119. Would you be able to add the |
|
/test e2e-agent-compact-ipv4-iso-no-registry |
|
@ptalgulk01 I updated the PR so those jobs may need to be deployed again. Thank you. |
|
/test e2e-agent-compact-ipv4-iso-no-registry |
cc @yuqi-zhang |
|
/verified by ci/prow/e2e-agent-compact-ipv4-iso-no-registry |
|
@bfournie: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/test unit |
|
Manually adding valid-bug as this is subject to an approved SBAR. |
|
@bfournie: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Backport the following PRs:
#5765
#5721
#6003
#6041
#6070
#5988
#5841
#6100
#6109
#6146
#6145
#6159
#6280
- What I did
- How to verify it
- Description for the changelog