OADP-7882: add dpa config to disable early csi polling interval#2181
OADP-7882: add dpa config to disable early csi polling interval#2181weshayutin merged 1 commit intoopenshift:oadp-1.6from
Conversation
|
@sseago: This pull request references OADP-7882 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: openshift/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
wfm.. |
|
now test w/ feature turned off now.. run another backup |
|
1 more time for nvidia :) |
4f70b15 to
80dbe93
Compare
|
If you could link pr in velero that reads this env would be appreciated |
If not disabled, add env var to velero to enable early csi polling
80dbe93 to
43b26e0
Compare
|
|
/retest ci/prow/4.18-images |
|
/test ci/prow/4.18-images |
|
/test 4.18-images |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kaovilai, shubham-pampattiwar, sseago, weshayutin The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/cherry-pick oadp-dev |
|
@sseago: new pull request created: #2185 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cherry-pick oadp-1.5 |
|
@sseago: new pull request created: #2186 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Why the changes were made
Added dpa config to disable early csi polling interval
If not disabled, add env var to velero to enable early csi polling. This is needed to ensure that for windows VMs the snapshots are done within 10 seconds.
How to test the changes made
If the disable flag isn't set, the velero pod should have the env var CSI_SNAPSHOT_EARLY_FREQUENT_POLLING set to true, else it should not be set.
If the env var is true, then when waiting for CSI snaphandle, there should be polling logging every 1 second at first, otherwise it should be every 5 seconds.