[oadp-dev] OADP-7882: add dpa config to disable early csi polling interval

[openshift-cherrypick-robot]

This is an automated cherry-pick of #2181

/assign sseago

Summary by CodeRabbit

• New Features

  • Users can now control CSI snapshot polling behavior through a new configuration option, allowing them to disable early frequent polling intervals during snapshot creation and readiness verification as needed.

• Tests

  • Added test coverage to validate proper handling of the CSI snapshot polling configuration setting in both enabled and disabled states.

[openshift-ci-robot]

@openshift-cherrypick-robot: Ignoring requests to cherry-pick non-bug issues: OADP-7882

Details

In response to this:

This is an automated cherry-pick of #2181

/assign sseago

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 1b6f4864-5fc5-44ed-990f-4758fabbb07b

📥 Commits

Reviewing files that changed from the base of the PR and between 36d616e and 76e4645.

📒 Files selected for processing (5)

• api/v1alpha1/dataprotectionapplication_types.go
• bundle/manifests/oadp.openshift.io_dataprotectionapplications.yaml
• config/crd/bases/oadp.openshift.io_dataprotectionapplications.yaml
• internal/controller/velero.go
• internal/controller/velero_test.go

---

Walkthrough

Adds a new optional boolean field DisableCSISnapshotEarlyFrequentPolling to the VeleroConfig struct and corresponding CRD schema. When not disabled, the Velero container automatically sets the CSI_SNAPSHOT_EARLY_FREQUENT_POLLING=true environment variable. Tests were updated to validate this new default behavior.

Changes

Cohort / File(s)	Summary
Type Definition api/v1alpha1/dataprotectionapplication_types.go	Added DisableCSISnapshotEarlyFrequentPolling optional boolean field to VeleroConfig struct.
CRD Schema Manifests bundle/manifests/oadp.openshift.io_dataprotectionapplications.yaml, config/crd/bases/oadp.openshift.io_dataprotectionapplications.yaml	Added disableCSISnapshotEarlyFrequentPolling boolean field to the CRD schema with documentation describing its purpose for controlling CSI snapshot polling behavior.
Controller Logic internal/controller/velero.go	Updated Velero container environment configuration to set CSI_SNAPSHOT_EARLY_FREQUENT_POLLING=true by default when CSI early frequent polling is not explicitly disabled.
Controller Tests internal/controller/velero_test.go	Updated test baselines to include the new CSI_SNAPSHOT_EARLY_FREQUENT_POLLING env var and added test case verifying that setting DisableCSISnapshotEarlyFrequentPolling: true prevents the env var from being set.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 9 | ❌ 3

❌ Failed checks (2 warnings, 1 inconclusive)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The PR description is largely incomplete, missing required sections for 'Why the changes were made' and 'How to test the changes made' specified in the repository's template.	Add explanations of why the CSI polling feature is needed and provide testing instructions. Since this is an automated cherry-pick, reference the original PR #2181 for context.
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.
Test Structure And Quality	❓ Inconclusive	Unable to retrieve and examine test file contents completely to assess Ginkgo test quality criteria including single responsibility, setup/cleanup patterns, timeout handling, assertion messages, and codebase consistency.	Review velero_test.go to verify each test has single responsibility, proper BeforeEach/AfterEach setup, appropriate WithTimeout/Eventually durations for async operations, descriptive assertion messages, and matches established test patterns.

✅ Passed checks (9 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main change: adding a DPA configuration option to disable early CSI polling interval, which aligns with all five modified files.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	All test names are stable and deterministic, fully complying with Ginkgo best practices with no dynamic patterns.
Microshift Test Compatibility	✅ Passed	PR does not introduce new Ginkgo e2e tests; changes are configuration and controller-level modifications only.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	No new Ginkgo e2e tests were added; only unit tests in internal/controller/velero_test.go were modified.
Topology-Aware Scheduling Compatibility	✅ Passed	PR introduces only an environment variable for Velero CSI snapshot polling without adding scheduling constraints incompatible with standard HA topology.
Ote Binary Stdout Contract	✅ Passed	No process-level stdout writes introduced by PR. All changes confined to controller logic, CRD schema definitions, and unit tests.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	PR modifies unit tests in internal/controller/velero_test.go, not e2e tests. No IPv4 assumptions or external connectivity requirements found.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Review rate limit: 9/10 reviews remaining, refill in 6 minutes.}

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-ci-robot]

@openshift-cherrypick-robot: This pull request references OADP-7882 which is a valid jira issue.

Details

In response to this:

This is an automated cherry-pick of #2181

/assign sseago

Summary by CodeRabbit

• New Features

• Users can now control CSI snapshot polling behavior through a new configuration option, allowing them to disable early frequent polling intervals during snapshot creation and readiness verification as needed.

• Tests

• Added test coverage to validate proper handling of the CSI snapshot polling configuration setting in both enabled and disabled states.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[shubham-pampattiwar]

/lgtm

[sseago]

/test 4.23-e2e-test-aws

[sseago]

/test 4.23-e2e-test-aws

[shubham-pampattiwar]

/override ci/prow/4.23-e2e-test-aws

[openshift-ci]

@shubham-pampattiwar: Overrode contexts on behalf of shubham-pampattiwar: ci/prow/4.23-e2e-test-aws

Details

In response to this:

/override ci/prow/4.23-e2e-test-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, shubham-pampattiwar, weshayutin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [shubham-pampattiwar]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.