STOR-3001: add TLS scanner for vsphere problem detector - #82214
Conversation
|
@dfajmon: This pull request references STOR-3001 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: ⛔ Files ignored due to path filters (4)
📒 Files selected for processing (4)
WalkthroughThe vSphere Problem Detector CI configurations register the ChangesvSphere TLS scanner integration
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
/pj-rehearse pull-ci-openshift-vsphere-problem-detector-main-tls-scanner-modern-profile-vsphere-problem-detector |
|
/pj-rehearse pull-ci-openshift-vsphere-problem-detector-main-tls-scanner-vsphere-problem-detector |
|
@dfajmon: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
1 similar comment
|
@dfajmon: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/retest |
|
/pj-rehearse pull-ci-openshift-vsphere-problem-detector-main-tls-scanner-modern-profile-vsphere-problem-detector |
|
/pj-rehearse pull-ci-openshift-vsphere-problem-detector-main-tls-scanner-vsphere-problem-detector |
|
@dfajmon: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
1 similar comment
|
@dfajmon: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse pull-ci-openshift-vsphere-problem-detector-main-tls-scanner-vsphere-problem-detector |
|
/pj-rehearse pull-ci-openshift-vsphere-problem-detector-main-tls-scanner-modern-profile-vsphere-problem-detector |
|
@dfajmon: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
1 similar comment
|
@dfajmon: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
a06d6b3 to
d03f3bb
Compare
|
/pj-rehearse pull-ci-openshift-vsphere-problem-detector-main-tls-scanner-modern-profile-vsphere-problem-detector |
|
/pj-rehearse pull-ci-openshift-vsphere-problem-detector-main-tls-scanner-vsphere-problem-detector |
|
@dfajmon: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
1 similar comment
|
@dfajmon: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
d03f3bb to
d5c4a8f
Compare
|
/pj-rehearse pull-ci-openshift-vsphere-problem-detector-main-tls-scanner-modern-profile-vsphere-problem-detector |
|
/pj-rehearse pull-ci-openshift-vsphere-problem-detector-main-tls-scanner-vsphere-problem-detector |
|
@dfajmon: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@dfajmon: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
d5c4a8f to
7ffbd67
Compare
|
/pj-rehearse pull-ci-openshift-vsphere-problem-detector-main-tls-scanner-vsphere-problem-detector |
|
@dfajmon: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse pull-ci-openshift-vsphere-problem-detector-main-tls-scanner-modern-profile-vsphere-problem-detector |
|
@dfajmon: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
7ffbd67 to
88c905b
Compare
|
/pj-rehearse pull-ci-openshift-vsphere-problem-detector-main-tls-scanner-vsphere-problem-detector |
|
@dfajmon: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
[REHEARSALNOTIFIER]
A total of 42 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs. A full list of affected jobs can be found here Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/pj-rehearse pull-ci-openshift-vsphere-problem-detector-release-4.23-tls-scanner-vsphere-problem-detector |
|
@RomanBednar: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/lgtm After the jobs fail successfully you can ack the rehearsals and the PR will merge. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dfajmon, RomanBednar The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/pj-rehearse pull-ci-openshift-vsphere-problem-detector-main-tls-scanner-vsphere-problem-detector |
|
@dfajmon: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@dfajmon: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/pj-rehearse ack |
|
/pj-rehearse ack |
|
@dfajmon: your |
1 similar comment
|
@dfajmon: your |
|
/pj-rehearse ack |
|
@dfajmon: your |
|
/pj-rehearse ack |
|
@dfajmon: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
e1b1080
into
openshift:main
Add a TLS scanner CI job for the vsphere problem detector to verify TLS compliance.
Summary by CodeRabbit
Adds optional TLS compliance scanner coverage to the OpenShift CI configuration for the vSphere Problem Detector across the
main,release-4.23,release-5.0, andrelease-5.1streams.tls-scanner-toolbase image (tls-scannerimage in thetls-scannernamespace).tls-scanner-vsphere-problem-detectortest workflow for thevsphere-elasticcluster profile that runs via theipi-vsphereworkflow.tls-13andtls-scanner-runrefs with TLS 1.3 adherence enabled (TLS_13_ENABLE_TLS_ADHERENCE: "true",TLS_13_TLS_ADHERENCE_POLICY: StrictAllComponents) and configures scanning foropenshift-cluster-storage-operator(1 CPU, 1Gi memory).