MCO-2451: Add automated TLS scanning presubmit for the MCO - #82232
Conversation
|
@isabella-janssen: This pull request references MCO-2451 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/valid-reference
openshift-ci
Bot
added
the
approved
WalkthroughAdds the ChangesTLS PQC readiness configuration
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 error, 1 warning)
✅ Passed checks (13 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
[REHEARSALNOTIFIER]
A total of 186 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs. A full list of affected jobs can be found here Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@ci-operator/config/openshift/machine-config-operator/openshift-machine-config-operator-main.yaml`:
- Around line 773-785: The tls-pqc-readiness presubmit is manual-only because
always_run is false and no file-change trigger is configured. In both
ci-operator/config/openshift/machine-config-operator/openshift-machine-config-operator-main.yaml
(lines 773-785) and
ci-operator/config/openshift/machine-config-operator/openshift-machine-config-operator-release-5.0.yaml
(lines 774-786), update the tls-pqc-readiness job to run automatically by
setting always_run to true or adding an appropriate
run_if_changed/skip_if_only_changed pattern.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: f2ae51c5-9bd7-449a-99de-1106413a7f69
⛔ Files ignored due to path filters (2)
ci-operator/jobs/openshift/machine-config-operator/openshift-machine-config-operator-main-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/machine-config-operator/openshift-machine-config-operator-release-5.0-presubmits.yamlis excluded by!ci-operator/jobs/**
📒 Files selected for processing (2)
ci-operator/config/openshift/machine-config-operator/openshift-machine-config-operator-main.yamlci-operator/config/openshift/machine-config-operator/openshift-machine-config-operator-release-5.0.yaml
|
/testwith pull-ci-openshift-machine-config-operator-main-tls-pqc-readiness openshift/machine-config-operator#6297 |
|
@isabella-janssen, |
|
@isabella-janssen: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cheesesashimi, isabella-janssen The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/pj-rehearse skip We will post-merge verify by running the new pre-submit on openshift/machine-config-operator#6297 |
|
@isabella-janssen: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
openshift-merge-bot
Bot
added
the
rehearsals-ack
3 participants
This adds a presubmit based on the TLS scanning tool described in https://github.com/richardsonnick/tls-scanner/tree/docs/running-binary-directly#cicd-workflow-recommended for the MCO. For now the job is optional and should be run manually on PRs. Once we know the test is stable, it will be turned on to run automatically and be required.
Summary by CodeRabbit
Adds an optional TLS/PQC readiness presubmit to the Machine Config Operator CI for main and release-5.0 configurations. The job uses the
tls-scanner-toolbase image, runs thetls-13andtls-scanner-runtests on AWS with PQC scanning enabled, and is configured not to run on every change.