Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,10 @@ base_images:
name: tests-private
namespace: ci
tag: "4.22"
tls-scanner-tool:
name: tls-scanner
namespace: tls-scanner
tag: tls-scanner-tool
binary_build_commands: make build
build_root:
from_repository: true
Expand Down Expand Up @@ -54,6 +58,14 @@ tests:
skip_if_only_changed: ^docs/|^\.tekton/|^rpms\.(.*)\.yaml$|^renovate.json$|\.md$|^(?:.*/)?(?:\.gitignore|OWNERS|PROJECT|LICENSE)$
steps:
cluster_profile: openshift-org-aws
env:
PQC_CHECK: "true"
SCAN_NAMESPACE: openshift-machine-api
SCANNER_CPU: 500m
SCANNER_MEMORY: 1Gi
test:
- ref: openshift-e2e-test
- ref: tls-scanner-run

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that we might be overwriting the default test(s) from workflow: openshift-e2e-aws. Compare this PR's run:
https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/test-platform-results/pr-logs/pull/openshift_release/82216/rehearse-82216-pull-ci-openshift-cluster-autoscaler-operator-main-e2e-aws/2079562122261434368/artifacts/e2e-aws/
to another recent run:
https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/test-platform-results/pr-logs/pull/openshift_kubernetes-autoscaler/426/pull-ci-openshift-kubernetes-autoscaler-main-e2e-aws/2063700150554988544/artifacts/e2e-aws/
You will see that this PRs run is missing the directory for openshift-e2e-test/
I think you just need to add

    - ref: openshift-e2e-test

above the new test ref which is the default test from the workflow

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this Joel, you are right. I added this step and now I can see both directories (openshift-e2e-test and tls-scanner-run) here. Could you please take a look again?

workflow: openshift-e2e-aws
- as: e2e-aws-operator
skip_if_only_changed: ^docs/|^\.tekton/|^rpms\.(.*)\.yaml$|^renovate.json$|\.md$|^(?:.*/)?(?:\.gitignore|OWNERS|PROJECT|LICENSE)$|_test\.go$
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1869,9 +1869,6 @@ cluster_profiles:
secret: cluster-secrets-vsphere
konflux:
cluster_groups:
rh-stg:
- stone-stg-rh01
- stone-stage-p01
rh-prod:
- kflux-ocp-p01
- kflux-osp-p01
Expand All @@ -1881,3 +1878,6 @@ konflux:
- stone-prd-rh01
- stone-prod-p01
- stone-prod-p02
rh-stg:
- stone-stg-rh01
- stone-stage-p01