AUTOSCALE-893: implement tls-scanner for cluster-autoscaler-operator - #82216
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@LucasAndFlores: This pull request references AUTOSCALE-893 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "5.0.0" version, but no target version was set. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughThe cluster-autoscaler-operator workflow now includes the TLS scanner image and test configuration. The Konflux cluster profile mapping reorders the ChangesTLS scanner CI configuration
Cluster group ordering
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
/pj-rehearse pull-ci-openshift-cluster-autoscaler-operator-main-e2e-aws |
|
@LucasAndFlores: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse ack |
|
@LucasAndFlores: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
openshift-merge-bot
Bot
added
the
rehearsals-ack
joelsmith
left a comment
joelsmith
left a comment
There was a problem hiding this comment.
I think this change makes it skip the original E2E test. See my comment below.
| SCANNER_CPU: 500m | ||
| SCANNER_MEMORY: 1Gi | ||
| test: | ||
| - ref: tls-scanner-run |
There was a problem hiding this comment.
I think that we might be overwriting the default test(s) from workflow: openshift-e2e-aws. Compare this PR's run:
https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/test-platform-results/pr-logs/pull/openshift_release/82216/rehearse-82216-pull-ci-openshift-cluster-autoscaler-operator-main-e2e-aws/2079562122261434368/artifacts/e2e-aws/
to another recent run:
https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/test-platform-results/pr-logs/pull/openshift_kubernetes-autoscaler/426/pull-ci-openshift-kubernetes-autoscaler-main-e2e-aws/2063700150554988544/artifacts/e2e-aws/
You will see that this PRs run is missing the directory for openshift-e2e-test/
I think you just need to add
- ref: openshift-e2e-test
above the new test ref which is the default test from the workflow
There was a problem hiding this comment.
Thanks for catching this Joel, you are right. I added this step and now I can see both directories (openshift-e2e-test and tls-scanner-run) here. Could you please take a look again?
openshift-merge-bot
Bot
removed
the
rehearsals-ack
|
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/pj-rehearse pull-ci-openshift-cluster-autoscaler-operator-main-e2e-aws |
|
@LucasAndFlores: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse ack |
|
@LucasAndFlores: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
openshift-merge-bot
Bot
added
the
rehearsals-ack
|
/lgtm |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danilo-gemoli, elmiko, joelsmith, LucasAndFlores The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
c716ab7
into
openshift:main
…penshift#82216) * feat(cao): implement tls-scanner * chore(cao): add test command
5 participants
Summary by CodeRabbit
cluster-autoscaler-operatorAWS end-to-end workflow to runtls-scanneras an additional test step, including wiring a newtls-scanner-toolimage and setting scanner-specific environment variables (e.g.,PQC_CHECK,SCAN_NAMESPACE) and resource limits.ci-operator/step-registry/cluster-profiles/cluster-profiles-config.yamlby moving therh-stgblock to follow therh-prodblock, without changing therh-stgcontents.