Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,10 @@ base_images:
name: "4.21"
namespace: ocp
tag: vertical-pod-autoscaler-operator
tls-scanner-tool:
name: tls-scanner
namespace: tls-scanner
tag: tls-scanner-tool
ubi-python-311:
name: ubi-python-311
namespace: ocp
Expand Down Expand Up @@ -135,6 +139,11 @@ tests:
skip_if_only_changed: ^docs/|^\.github|\.md$|^(?:.*/)?(?:\.gitignore|OWNERS|OWNERS_ALIASES|PROJECT|LICENSE)$
steps:
cluster_profile: openshift-org-aws
env:
PQC_CHECK: "true"
SCAN_NAMESPACE: openshift-vertical-pod-autoscaler
SCANNER_CPU: 500m
SCANNER_MEMORY: 1Gi
test:
- as: install
cli: latest
Expand All @@ -156,6 +165,7 @@ tests:
resources:
requests:
cpu: 100m
- ref: tls-scanner-run

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "== file context =="
sed -n '140,200p' ci-operator/config/openshift/vertical-pod-autoscaler-operator/openshift-vertical-pod-autoscaler-operator-main.yaml

echo
echo "== relevant make targets / docs =="
rg -n "make update|ci-operator-config|jobs|registry-metadata|zz_generated_metadata|ci-operator/config/" Makefile .github . 2>/dev/null | head -n 200

echo
echo "== generated artifacts for this config =="
fd -a 'openshift-vertical-pod-autoscaler-operator-main.*' ci-operator/config/openshift/vertical-pod-autoscaler-operator 2>/dev/null || true
fd -a 'zz_generated_metadata*' ci-operator/config/openshift/vertical-pod-autoscaler-operator 2>/dev/null || true

echo
echo "== git status summary =="
git status --short

Repository: openshift/release

Length of output: 27173


🏁 Script executed:

#!/bin/bash
set -euo pipefail

repo_dir='ci-operator/config/openshift/vertical-pod-autoscaler-operator'
echo "== config files =="
git ls-files "${repo_dir}" | sed -n '1,50p'

echo
echo "== generated job files for openshift/vertical-pod-autoscaler-operator =="
git ls-files 'ci-operator/jobs/openshift/vertical-pod-autoscaler-operator' | sed -n '1,50p'

echo
echo "== occurrences of tls-scanner-run =="
rg -n "tls-scanner-run" ci-operator ci-operator/jobs ci-operator/step-registry 2>/dev/null || true

echo
echo "== make update target =="
sed -n '68,80p' Makefile

Repository: openshift/release

Length of output: 25680


Regenerate the generated Prow jobs. Adding tls-scanner-run changes this ci-operator config, so run make update to keep the generated files under ci-operator/jobs/openshift/vertical-pod-autoscaler-operator/ in sync before merging.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In
`@ci-operator/config/openshift/vertical-pod-autoscaler-operator/openshift-vertical-pod-autoscaler-operator-main.yaml`
at line 168, Regenerate the Prow job files affected by the tls-scanner-run entry
in the ci-operator configuration by running make update, ensuring the generated
files under ci-operator/jobs/openshift/vertical-pod-autoscaler-operator/ are
synchronized.

Sources: Coding guidelines, Learnings

workflow: ipi-aws
- as: e2e-aws-upgrade
skip_if_only_changed: ^docs/|^\.github|\.md$|^(?:.*/)?(?:\.gitignore|OWNERS|OWNERS_ALIASES|PROJECT|LICENSE)$
Expand Down