AUTOSCALE-891: VPA: Add PQC ML-KEM CI test - #82247
Conversation
WalkthroughThe VPA operator CI configuration adds a ChangesTLS scanner CI integration
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
Suggested labels: Suggested reviewers: Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 error)
✅ Passed checks (14 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[REHEARSALNOTIFIER]
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals. Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@ci-operator/config/openshift/vertical-pod-autoscaler-operator/openshift-vertical-pod-autoscaler-operator-main.yaml`:
- Line 168: Regenerate the Prow job files affected by the tls-scanner-run entry
in the ci-operator configuration by running make update, ensuring the generated
files under ci-operator/jobs/openshift/vertical-pod-autoscaler-operator/ are
synchronized.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 7d14e175-272a-4cb4-b66f-184fc02fbc06
📒 Files selected for processing (1)
ci-operator/config/openshift/vertical-pod-autoscaler-operator/openshift-vertical-pod-autoscaler-operator-main.yaml
| resources: | ||
| requests: | ||
| cpu: 100m | ||
| - ref: tls-scanner-run |
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "== file context =="
sed -n '140,200p' ci-operator/config/openshift/vertical-pod-autoscaler-operator/openshift-vertical-pod-autoscaler-operator-main.yaml
echo
echo "== relevant make targets / docs =="
rg -n "make update|ci-operator-config|jobs|registry-metadata|zz_generated_metadata|ci-operator/config/" Makefile .github . 2>/dev/null | head -n 200
echo
echo "== generated artifacts for this config =="
fd -a 'openshift-vertical-pod-autoscaler-operator-main.*' ci-operator/config/openshift/vertical-pod-autoscaler-operator 2>/dev/null || true
fd -a 'zz_generated_metadata*' ci-operator/config/openshift/vertical-pod-autoscaler-operator 2>/dev/null || true
echo
echo "== git status summary =="
git status --shortRepository: openshift/release
Length of output: 27173
🏁 Script executed:
#!/bin/bash
set -euo pipefail
repo_dir='ci-operator/config/openshift/vertical-pod-autoscaler-operator'
echo "== config files =="
git ls-files "${repo_dir}" | sed -n '1,50p'
echo
echo "== generated job files for openshift/vertical-pod-autoscaler-operator =="
git ls-files 'ci-operator/jobs/openshift/vertical-pod-autoscaler-operator' | sed -n '1,50p'
echo
echo "== occurrences of tls-scanner-run =="
rg -n "tls-scanner-run" ci-operator ci-operator/jobs ci-operator/step-registry 2>/dev/null || true
echo
echo "== make update target =="
sed -n '68,80p' MakefileRepository: openshift/release
Length of output: 25680
Regenerate the generated Prow jobs. Adding tls-scanner-run changes this ci-operator config, so run make update to keep the generated files under ci-operator/jobs/openshift/vertical-pod-autoscaler-operator/ in sync before merging.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In
`@ci-operator/config/openshift/vertical-pod-autoscaler-operator/openshift-vertical-pod-autoscaler-operator-main.yaml`
at line 168, Regenerate the Prow job files affected by the tls-scanner-run entry
in the ci-operator configuration by running make update, ensuring the generated
files under ci-operator/jobs/openshift/vertical-pod-autoscaler-operator/ are
synchronized.
Sources: Coding guidelines, Learnings
|
/pj-rehearse pull-ci-openshift-vertical-pod-autoscaler-operator-main-e2e-aws-olm |
|
@shyadav10: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
shyadav10
changed the title
openshift-ci-robot
added
the
jira/valid-reference
|
@shyadav10: This pull request references AUTOSCALE-891 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/test rehearse-82247-pull-ci-openshift-vertical-pod-autoscaler-operator-main-e2e-aws-olm |
|
It looks like the test run never really got going. |
|
@joelsmith: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/retest |
|
/pj-rehearse pull-ci-openshift-vertical-pod-autoscaler-operator-main-e2e-aws-olm |
|
@shyadav10: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@shyadav10: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: joelsmith, shyadav10 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
|
/pj-rehearse ack |
|
@shyadav10: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
openshift-merge-bot
Bot
added
the
rehearsals-ack
3 participants
Jira link: https://redhat.atlassian.net/browse/AUTOSCALE-891
Summary by CodeRabbit