bird2, bird3: license identifier, bird3cl title and CPE ID - #1193
Merged
Conversation
Replace the free-form license boilerplate with an SPDX license identifier, in line with the other packages in this feed. Signed-off-by: Josef Schlehofer <pepe.schlehofer@gmail.com> Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
This was referenced Aug 6, 2026
The bird3cl package was titled as "(v2)" client although it is built from BIRD 3. Fix the copy-paste leftover from the bird2 Makefile. Also add PKG_CPE_ID, the same product identifier as used by bird2, so published CVEs can be matched against this package. Signed-off-by: Josef Schlehofer <pepe.schlehofer@gmail.com> Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
openwrt
Bot
added
the
not following guidelines
/etc/bird4.conf and /etc/bird6.conf are left over from the bird1 packages, which shipped a separate configuration file per address family. bird2 is a single daemon handling both and installs /etc/bird.conf only, so the two entries refer to files this package never creates. Signed-off-by: Josef Schlehofer <pepe.schlehofer@gmail.com> Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
/etc/bird4.conf and /etc/bird6.conf are left over from the bird1 packages, which shipped a separate configuration file per address family. bird3 is a single daemon handling both and installs /etc/bird.conf only, so the two entries refer to files this package never creates. Signed-off-by: Josef Schlehofer <pepe.schlehofer@gmail.com> Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
The script was a single bare command with no shebang and a trailing space. Every other test-version.sh in the OpenWrt feeds starts with #!/bin/sh and dispatches on $PKG_NAME, so that a sub-package added later fails loudly instead of being probed with a command that happens to work for a different package. Also use grep -F, so the dots in the version are not treated as regular expression wildcards, and record why the daemon is checked rather than birdc/birdcl, which do not report a version of their own. Signed-off-by: Josef Schlehofer <pepe.schlehofer@gmail.com> Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
The script was a single bare command with no shebang and a trailing space. Every other test-version.sh in the OpenWrt feeds starts with #!/bin/sh and dispatches on $PKG_NAME, so that a sub-package added later fails loudly instead of being probed with a command that happens to work for a different package. Also use grep -F, so the dots in the version are not treated as regular expression wildcards, and record why the daemon is checked rather than birdc/birdcl, which do not report a version of their own. Signed-off-by: Josef Schlehofer <pepe.schlehofer@gmail.com> Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
openwrt
Bot
removed
the
not following guidelines
The patch carried only a subject line and a placeholder commit id, so nothing recorded why marking struct top_hash_entry as PACKED fixes a bus error, or whether it can be dropped. Restore the description and the sign-off from the commit that introduced it in this feed, keeping the original author's wording, and record the upstream status. Verified that BIRD 2.19.2 still declares the structure without any alignment attribute, so the patch is still needed. The header keeps the "---" separator the sibling patch uses, and orders Signed-off-by last among the trailers. Signed-off-by: Josef Schlehofer <pepe.schlehofer@gmail.com> Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Member
Author
|
Guys, kind reminder. Can I merge this? Can you check those conffiles entries on the router? |
Contributor
|
LGTM! :) |
tohojo
approved these changes
Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small fixes towards moving the packages to openwrt/packages (#184):
Maintainers: @tohojo, @PolynomialDivision