batmand, vis: drop dead build flags, fix revision info, add test-version.sh - #1195
Open
BKPepe wants to merge 3 commits into
Open
batmand, vis: drop dead build flags, fix revision info, add test-version.sh#1195BKPepe wants to merge 3 commits into
BKPepe wants to merge 3 commits into
Conversation
BKPepe
commented
Aug 6, 2026
Comment on lines
+1
to
+13
| From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001 | ||
| From: Josef Schlehofer <pepe.schlehofer@gmail.com> | ||
| Date: Wed, 6 Aug 2026 12:00:00 +0200 | ||
| Subject: [PATCH] allocate: include string.h for memcpy | ||
|
|
||
| memcpy() is used in debugRealloc() without including string.h. Since | ||
| GCC 14 treats implicit function declarations as a hard error, the | ||
| build fails: | ||
|
|
||
| allocate.c:349:17: error: implicit declaration of function | ||
| 'memcpy' [-Wimplicit-function-declaration] | ||
|
|
||
| Signed-off-by: Josef Schlehofer <pepe.schlehofer@gmail.com> |
Member
Author
There was a problem hiding this comment.
This PR carries a small patch adding #include <string.h> to allocate.c, because memcpy() is used there without it and GCC 14 turns implicit declarations into errors, so batmand currently fails to build.
It looks like a fix that belongs upstream rather than in the feed.
BKPepe
force-pushed
the
batmand-vis-cleanup
branch
from
August 6, 2026 11:56
29da6f0 to
8fbbc12
Compare
Drop the EXTRA_CFLAGS assignment from MAKE_FLAGS. The batmand build system never references an EXTRA_CFLAGS variable, so none of these flags were applied: the debug defines are already set via CPPFLAGS by the upstream Makefile and REVISION_VERSION is not used anywhere in the source. Also add test-version.sh for the CI runtime tests. The package version is derived from PKG_SOURCE_DATE and the git hash, which the binary does not report, so the generic version check always failed. Check that the binary starts and prints its version banner instead. Signed-off-by: Josef Schlehofer <pepe.schlehofer@gmail.com> Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
The REVISION make variable was set to PKG_REV, which is not defined anywhere, so the binary was built without revision information. Use PKG_SOURCE_VERSION, like batmand does, so `vis -v` identifies the packaged git snapshot. Drop the EXTRA_CFLAGS assignment from MAKE_FLAGS. The vis build system never references an EXTRA_CFLAGS variable, so none of these flags were applied: the debug defines are already set via CPPFLAGS by the upstream Makefile and REVISION_VERSION is not used anywhere in the source. Also add test-version.sh for the CI runtime tests. The package version is derived from PKG_SOURCE_DATE and the git hash, which the binary does not report, so the generic version check always failed. Check that the binary starts and prints its version banner instead. Signed-off-by: Josef Schlehofer <pepe.schlehofer@gmail.com> Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
allocate.c uses memcpy() without including string.h. GCC 14 treats
implicit function declarations as a hard error, so the package
failed to build:
allocate.c:349:17: error: implicit declaration of function
'memcpy' [-Wimplicit-function-declaration]
Add a patch which includes string.h.
Signed-off-by: Josef Schlehofer <pepe.schlehofer@gmail.com>
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
BKPepe
force-pushed
the
batmand-vis-cleanup
branch
from
August 11, 2026 11:07
8fbbc12 to
103bc5f
Compare
openwrt
Bot
added
the
not following guidelines
openwrt
Bot
added
the
release/25.12
Member
Author
|
[allow cherry-pick] |
openwrt
Bot
removed
the
not following guidelines
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EXTRA_CFLAGS='...'assignment that the upstream build systems never reference, so none of those flags were ever applied (the debug defines are already set via CPPFLAGS upstream and REVISION_VERSION is unused in both sources). Drop it.test-version.shfor the CI runtime tests: the package versions are derived from PKG_SOURCE_DATE and the git hash, which the binaries do not report, so the generic version check could never pass. Check the version banners viabatmand -v/vis -vinstead.Maintainer: @elektra42