treewide: add test-version.sh for packages which cannot pass the generic version check - #1196
Merged
Merged
Conversation
ahcpd does not provide any option to report its version, so the generic version check of the CI runtime tests always fails for this package. Override it by checking that the binary starts and prints its usage instead. Signed-off-by: Josef Schlehofer <pepe.schlehofer@gmail.com> Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
babel-pinger does not provide any option to report its version, so the generic version check of the CI runtime tests always fails for this package. Skip the version check. Signed-off-by: Josef Schlehofer <pepe.schlehofer@gmail.com> Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
naywatch is a watchdog shell script which does not provide any option to report its version, so the generic version check of the CI runtime tests fails for this package. On top of that, the generic check executes each installed executable with several flags to probe for the version, which must never happen for a watchdog script that may trigger a reboot of the test environment. Providing a test-version.sh both skips the version probing of the binary and overrides the version check. Signed-off-by: Josef Schlehofer <pepe.schlehofer@gmail.com> Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
The package version is derived from PKG_SOURCE_DATE and the git hash, which neither ohybridproxy nor zonestitcher report, so the generic version check of the CI runtime tests always fails for these packages. Skip the version check. Signed-off-by: Josef Schlehofer <pepe.schlehofer@gmail.com> Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
The package version is derived from PKG_SOURCE_DATE and the git hash, which the binary does not report, so the generic version check of the CI runtime tests always fails for this package. Skip the version check. Signed-off-by: Josef Schlehofer <pepe.schlehofer@gmail.com> Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
prince requires a configuration file and does not provide any option to report its version, so the generic version check of the CI runtime tests always fails for this package. Skip the version check. Signed-off-by: Josef Schlehofer <pepe.schlehofer@gmail.com> Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
The patch carried the raw `git format-patch` output including the
"diff --git"/"index" lines and the trailing git version signature,
which the refresh check of the CI strips, so any PR touching this
package failed with:
Dirty patches detected, please refresh and review the diff
Normalize the patch to the refreshed form. No content change.
Signed-off-by: Josef Schlehofer <pepe.schlehofer@gmail.com>
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
BKPepe
force-pushed
the
add-test-version-scripts
branch
from
August 6, 2026 10:14
f6e5daa to
fbd3f44
Compare
The comment claimed the version check has to be skipped because running the script may trigger a reboot. That is not what happens: reboot_now() is only reached once naywatch has seen a neighbour (ACTIVE=1) and then lost it for more than MIN_KICK intervals, and the watchdog branch is not taken either, because the probe leaves use_watchdog empty. What does happen is that naywatch takes positional arguments - check interval, watchdog timeout, and so on - rather than options, so a probe flag ends up as the check interval and the script enters its monitoring loop instead of reporting anything, until the probe timeout kills it. The override stays, only its justification is corrected. Signed-off-by: Josef Schlehofer <pepe.schlehofer@gmail.com> Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The generic version check of the CI runtime tests requires at least one executable of a package to report PKG_VERSION. These packages can never pass it:
With these in place, any future PR touching these packages gets a green runtime test instead of a guaranteed failure.