fix(security): recognised sanitizer for js/log-injection (follow-up to #1398) - #1400
Merged
Conversation
The previous fix sanitized the unhandled-message `kind` with a character-class replace that CodeQL does not model as a sanitizer, so js/log-injection reopened as alert #16 on the rewritten line. Switch to encodeURIComponent, which CodeQL recognises, keeping the value safe to log. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1398.
After #1398 merged, CodeQL's develop scan closed alerts 10/11/15 but opened a new
js/log-injectionalert (#16) onexamples/voice/static/plain/index.html: the sanitizer used there (String.replace(/[^\w.:-]/g, '')) strips newlines but is not a form CodeQL models as a sanitizer, so the taintedkindstill flowed intoconsole.debug.This switches to
encodeURIComponent(String(m?.kind ?? '')), which CodeQL recognises as a log-injection sanitizer — clearing #16 while keeping the value safe to log.🤖 Generated with Claude Code