Skip to content

fix(security): recognised sanitizer for js/log-injection (follow-up to #1398) #1400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pathosDev merged 1 commit into from
Sep 1, 2026
Merged

fix(security): recognised sanitizer for js/log-injection (follow-up to #1398) #1400

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions examples/voice/static/plain/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -494,12 +494,10 @@
.with({ kind: 'voice-incoming-end' }, (m) => endIncoming(m.from))
.with({ kind: 'system' }, () => { /* informational */ })
.otherwise(() => {
// Log only the sanitized `kind` tag, never the raw server payload,
// so a crafted message can't forge console entries (CodeQL
// js/log-injection).
const kind =
typeof m?.kind === 'string' ? m.kind.replace(/[^\w.:-]/g, '') : '(unknown)';
console.debug('unhandled server msg kind:', kind);
// Encode the user-controlled value before logging so a crafted
// message can't forge console entries. encodeURIComponent is a
// sanitizer CodeQL recognises for js/log-injection.
console.debug('unhandled server msg kind:', encodeURIComponent(String(m?.kind ?? '')));
Comment thread
pathosDev marked this conversation as resolved.
Dismissed
});
}

Expand Down