fix: split SIGUSR1/SIGHUP reload signal handling into platform files#1233
Merged
Conversation
syscall.SIGUSR1 doesn't exist on Windows, breaking the windows/amd64 release binary build and leaving an empty asset that GitHub then rejected during release upload.
go build ./cmd/leafwiki/main.go only compiles that single file, silently dropping sibling files in the package (e.g. the new signals_unix.go/signals_windows.go). Build the package directory instead so all files are included.
Unanchored "leafwiki" matched any path component, so files added under cmd/leafwiki/ required -f to stage. Anchoring to /leafwiki keeps the root build artifact ignored without shadowing the package directory.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
syscall.SIGUSR1 doesn't exist on Windows, breaking the windows/amd64 release binary build and leaving an empty asset that GitHub then rejected during release upload.