fix: detach stdin from the migrate run — it swallowed the deploy script - #2
Open
MauriceDellin wants to merge 1 commit into
Open
fix: detach stdin from the migrate run — it swallowed the deploy script#2MauriceDellin wants to merge 1 commit into
MauriceDellin wants to merge 1 commit into
Conversation
The remote half of deploy.sh arrives on stdin via the ssh heredoc. `docker compose run` without -T attaches the migrate container to that stdin, so it consumes the rest of the script: bash hits EOF right after the migration, `up -d web` and the health poll never run, and the job exits 0 — a silent no-op deploy that reports success. Only stateful apps (§ 6.2 PLX) declare a migrate service, which is why the stateless plexus-ms.org deploys never surfaced this. Fixes plexus-ms#1 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1.
The remote half of
scripts/deploy.sharrives on stdin (ssh heredoc).docker compose runwithout-Tattaches the one-shot migrate container to that stdin, so it consumes the remainder of the script — bash reads EOF right after the migration,dc up -d weband the health poll never execute, and the job exits 0: a silent no-op deploy that reports success.Only stateful apps (§ 6.2 PLX) declare a
migrateservice, which is why the stateless plexus-ms.org deploys never surfaced this. Verified on tenantmedocs(first stateful-app deploy): with-Tthe full pull → migrate → up → healthcheck chain runs; without it the log stops dead after the migration output.One-character fix plus a comment explaining why the flag is load-bearing.
🤖 Generated with Claude Code