Skip to content

fix: detach stdin from the migrate run — it swallowed the deploy script #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MauriceDellin wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: detach stdin from the migrate run — it swallowed the deploy script #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion scripts/deploy.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,10 @@ IMAGE="$IMAGE" dc pull web
# flag is only needed for the existence check, since `config --services`
# hides profiled services by default.
if IMAGE="$IMAGE" dc --profile migrate config --services 2>/dev/null | grep -qx migrate; then
IMAGE="$IMAGE" dc run --rm migrate
# -T: never attach stdin — this script itself arrives on stdin (ssh heredoc),
# and an attached migrate container would swallow the remaining lines,
# silently skipping `up` and the health poll (plexus-ms/ci-cd#1).
IMAGE="$IMAGE" dc run -T --rm migrate
fi
IMAGE="$IMAGE" dc up -d web

Expand Down