lowram: Eliminate y vector in REDUCE_RAM mode in sign#1031
Merged
hanno-becker merged 1 commit intomainfrom Apr 28, 2026
Merged
Conversation
Contributor
CBMC Results (ML-DSA-65)Full Results (194 proofs)
|
Contributor
CBMC Results (ML-DSA-87)Full Results (194 proofs)
|
Contributor
CBMC Results (ML-DSA-44)
Full Results (194 proofs)
|
4b9fcd1 to
cef9d32
Compare
c305d6f to
09dd2ba
Compare
fd688ec to
a700d21
Compare
Contributor
CBMC Results (ML-DSA-44, REDUCE-RAM)
Full Results (194 proofs)
|
Contributor
CBMC Results (ML-DSA-65, REDUCE-RAM)Full Results (194 proofs)
|
Contributor
CBMC Results (ML-DSA-87, REDUCE-RAM)Full Results (194 proofs)
|
649a423 to
2a9fad2
Compare
Contributor
hanno-becker
left a comment
There was a problem hiding this comment.
I am wary of the code duplication introduced here and furthered with the introduction of the lazy zvec, but I agree with you @mkannwischer that this is better discussed once everything is in place.
I'm happy to proceed with this PR once #1060 is merged and this one is rebased atop (as I understand it the plan?)
2a9fad2 to
18d019f
Compare
Contributor
Author
Rebased now. |
Add mld_yvec following the lazy polyvec pattern: in REDUCE_RAM mode it stores only the seed and nonce and regenerates y[i] on demand. The fused matrix-vector helper mld_polyvec_matrix_pointwise_montgomery_yvec samples y column-by-column in REDUCE_RAM mode. Adjust CBMC proofs accordingly. Signed-off-by: Matthias J. Kannwischer <matthias@zerorisc.com>
18d019f to
4e2952e
Compare
hanno-becker
approved these changes
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add mld_yvec following the lazy polyvec pattern: in REDUCE_RAM mode it
stores only the seed and nonce and regenerates y[i] on demand. The
fused matrix-vector helper mld_polyvec_matrix_pointwise_montgomery_yvec
samples y column-by-column in REDUCE_RAM mode.
MLD_CONFIG_REDUCE_RAMmode #1060