test(search): skip TestSearchLimitOffset on RESP3 for standalone too#526
Open
kiryazovi-redis wants to merge 1 commit into
Open
Conversation
FT.SEARCH on RESP3 ignores the LIMIT offset server-side (RediSearch#10369), returning [0, offset+count) instead of [offset, offset+count). The existing skip only covered cluster+RESP3, but the same module behaviour reproduces on a standalone Redis Enterprise database, so TestSearchLimitOffset(standalone,Resp3) fails 10/10. Broaden the skip to all RESP3 runs (cluster and standalone) until the module bug is resolved; standalone+RESP3 offset behaviour still needs module-team confirmation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TestSearchLimitOffsetis affected by a known RediSearch LIMIT/offset behaviourdifference under RESP3 (RediSearch#10369). The test already skipped that case for
cluster, but the same RESP3 behaviour occurs on standalone as well, so the
test fails there when run with RESP3.
What changed
TestSearchLimitOffsetis skipped on RESP3 forstandalone in addition to cluster, until RediSearch#10369 is resolved.
Test-only change.
Test plan
Prepared with AI assistance and reviewed under my account.
Note
Low Risk
Test-only change; no production or client library behavior is modified.
Overview
TestSearchLimitOffsetis skipped on any RESP3 run, not only cluster, because RediSearch#10369 (incorrectFT.SEARCHLIMIToffset) also shows up on standalone Redis Enterprise.The skip condition drops the cluster check and only uses
TestContext.Current.GetRunProtocol().IsResp3(), with comments and the skip message updated to match.Reviewed by Cursor Bugbot for commit dd31e6f. Bugbot is set up for automated code reviews on this repo. Configure here.