Skip to content

test(search): skip TestSearchLimitOffset on RESP3 for standalone too #526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kiryazovi-redis wants to merge 1 commit into
base: master
Choose a base branch
from
Open

test(search): skip TestSearchLimitOffset on RESP3 for standalone too #526

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions tests/NRedisStack.Tests/Search/SearchTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,12 +78,13 @@ public void TestSearchLimitOffset(string endpointId)
{
SkipClusterPre8(endpointId);

// Cluster + RESP3 ignores the LIMIT offset server-side: FT.SEARCH returns the window
// RESP3 ignores the LIMIT offset server-side: FT.SEARCH returns the window
// [0, offset+count) instead of [offset, offset+count). This is a RediSearch module bug,
// not a client bug (the raw wire reply already contains the wrong documents); skip until fixed.
// not a client bug (the raw wire reply already contains the wrong documents). It reproduces
// on both cluster and standalone Redis Enterprise databases, so skip both until fixed.
// https://github.com/RediSearch/RediSearch/issues/10369
Assert.SkipWhen(endpointId == EndpointsFixture.Env.Cluster && TestContext.Current.GetRunProtocol().IsResp3(),
"RediSearch#10369: FT.SEARCH on cluster+RESP3 ignores the LIMIT offset");
Assert.SkipWhen(TestContext.Current.GetRunProtocol().IsResp3(),
"RediSearch#10369: FT.SEARCH on RESP3 ignores the LIMIT offset (cluster and standalone)");

IDatabase db = GetCleanDatabase(endpointId);
var ft = db.FT();
Expand Down
Loading