[IO] Deprecate TStreamerElement::ESTLtype in favor of ROOT::ESTLType#15487
Merged
guitargeek merged 3 commits intoJun 18, 2026
Merged
Conversation
Test Results 19 files 19 suites 2d 21h 6m 28s ⏱️ For more details on these failures, see this check. Results for commit ccef75f. ♻️ This comment has been updated with latest results. |
guitargeek
force-pushed
the
deprecate_streamelem_stltype
branch
from
68e7442 to
ee85064
Compare
pcanal
reviewed
Dec 2, 2024
guitargeek
force-pushed
the
deprecate_streamelem_stltype
branch
2 times, most recently
from
274f14c to
4f47133
Compare
guitargeek
force-pushed
the
deprecate_streamelem_stltype
branch
from
4f47133 to
84967d8
Compare
guitargeek
force-pushed
the
deprecate_streamelem_stltype
branch
2 times, most recently
from
4601a5c to
5dc4a16
Compare
guitargeek
force-pushed
the
deprecate_streamelem_stltype
branch
2 times, most recently
from
a9d48bb to
ccef75f
Compare
pcanal
reviewed
Jun 18, 2026
A few classes have redundant declarations of `ESTLType` or `ESTLtype` enums, that over time have been centralized in `ROOT::ESTLType`. This patch deprecates usage of the historical copies in favor of the common `ROOT::ESTLType`.
The latter enumerators are now deprecated.
Cppyy::ResolveEnum() determines an enum's underlying integer type by JIT-compiling a probe expression of the form: ```c++ std::is_same<unsigned int, std::underlying_type<SomeEnum>::type>::value; ``` If the enum being resolved (or its enclosing scope) is marked deprecated, this purely internal introspection emits a `-Wdeprecated-declarations` warning to stderr. Since cppyy resolves enums while wrapping classes, the warning surfaces in ordinary PyROOT sessions that merely touch a class carrying such an enum. This started breaking a range of roottest tests (which diff process output against reference files) after the historical ESTLType/ESTLtype enum copies in TClassEdit, TDictionary and TStreamerElement were deprecated. Wrap the probe expression in clang diagnostic push/ignored/pop pragmas so that resolving a deprecated enum stays silent. 🤖 Done by AI.
guitargeek
force-pushed
the
deprecate_streamelem_stltype
branch
from
ccef75f to
266f34e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Superseeds #7234 so I can open a corresponding roottest PR.