[IO] Deprecate TStreamerElement::ESTLtype in favor of ROOT::ESTLType#7234
[IO] Deprecate TStreamerElement::ESTLtype in favor of ROOT::ESTLType#7234eguiraud wants to merge 2 commits into
Conversation
eguiraud
force-pushed
the
deprecate_streamelem_stltype
branch
from
cfe48af to
4880869
Compare
|
What the heck ubuntu16 😑 |
|
gcc 5.3, used in Ubuntu 16, does not support |
eguiraud
force-pushed
the
deprecate_streamelem_stltype
branch
from
3d1be6b to
42cc0ec
Compare
|
Mmmmh ok I have to figure out where |
eguiraud
force-pushed
the
deprecate_streamelem_stltype
branch
from
42cc0ec to
1c26638
Compare
A few classes have redundant declarations of `ESTLType` or `ESTLtype` enums, that over time have been centralized in `ROOT::ESTLType`. This patch deprecates usage of the historical copies in favor of the common `ROOT::ESTLType`. To do: - PyROOT uses TDictionary::ESTLType somewhere, might be in cppyy's core
The latter enumerators are now deprecated.
guitargeek
force-pushed
the
deprecate_streamelem_stltype
branch
from
1c26638 to
ab7e598
Compare
|
Starting build on |
|
I have updated the PR by rebasing on master, refreshing the version in the deprecation macros, and dropping the GCC 5 workaround because the minimum supported version is GCC 8 anyway: |
|
❤️ |
Test Results 9 files 9 suites 1d 22h 8m 43s ⏱️ For more details on these failures, see this check. Results for commit ab7e598. |
|
It looks like we need a companion |
|
Replaced by #15487. |
4 participants
I don't know if this is desirable or not, but I figured I would raise the issue.
TStreamerElement::ESTLtypeduplicatesROOT::ESTLTypeexactly, but with a lower-casetintype. It confused me when I found this out (and it turns out that I forgot to updateTStreamerElement::ESTLtypewhen I updatedROOT::ESTLType).I could not find any usage of
TStreamerElement::ESTLTypein ROOT, and ROOT compiles just fine without the enum, but just in case someone out there is using it, I'm proposing to deprecate it in 6.24 and remove it in 6.26.Feel free to close this PR if you don't think this makes sense.
UPDATE:
after discussion with @pcanal we decided that deprecation/removal is the right thing to do, and I extended the patch to
TDictionaryandTClassEdit.TBufferJSONhad some usage ofTClassEdit::ESTLTypewhich has now been substituted withROOT::ESTLType.UPDATE 2:
Since gcc 5 (the system compiler on Ubuntu 16) does not support deprecation of enumerators, I'm proposing to disable
R__DEPRECATEDfor that gcc version (it was already disabled for gcc 5.1 and 5.2 due to a different issue).