Convert UTF-8 errors to errors rather than None#1274
Merged
Conversation
Test that invalid UTF8 is represented as `Ok(None)` rather than an error, so that the behavior change in the next commit is visible.
DanielEScherzer
force-pushed
the
return-better-results
branch
from
ac40317 to
3ba6911
Compare
weihanglo
approved these changes
Jun 11, 2026
Convert `std::str::Utf8Error` into a git2 `Error` object and return an error case, rather than silently switching to `Ok(None)`.
Test that invalid UTF-8 is represented as `Ok(None)` rather than an error, so that the behavior change in the next commit is visible.
Convert `std::str::Utf8Error` into a git2 `Error` object and return an error case, rather than silently switching to `Ok(None)`. Since UTF-8 errors were the only way `Ok(None)` could be returned, switch from returning `Result<Option<&str>, Error>` to returning `Result<&str, Error>` now that the UTF-8 errors are handled with the `Err` variant.
DanielEScherzer
force-pushed
the
return-better-results
branch
from
3ba6911 to
397d7ab
Compare
ehuss
added
the
semver-breaking-change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.