Skip to content

Localize the Android 9.0.1 changelog title - #509

Closed
kavemang wants to merge 1 commit into
ryanbr:mainfrom
kavemang:fix/i18n-coverage-changelog-title
Closed

Localize the Android 9.0.1 changelog title#509
kavemang wants to merge 1 commit into
ryanbr:mainfrom
kavemang:fix/i18n-coverage-changelog-title

Conversation

@kavemang

Copy link
Copy Markdown

What changed

  • Route the Android 9.0.1 changelog title through uiString.
  • Add the title to the English, German, Spanish, and French Android string resources.

Why

The 9.0.1 release added this title as a hardcoded Kotlin literal on main. The i18n Coverage workflow audits the full merged tree, so that baseline violation caused every pull request to fail even when its diff was unrelated.

This removes the hardcoded literal and restores a clean i18n baseline without adding the unrelated fix to each affected pull request.

Validation

  • python3 Tools/i18n_audit.py --ci upstream/main
  • ./gradlew :app:compileFullDebugKotlin :app:testFullDebugUnitTest --tests com.noop.ui.GermanLocalizationTest
  • git diff --check

@digitalerdude

Copy link
Copy Markdown

This looks superseded — #514 landed the identical fix (same literal, same extraction into AppChangelog.kt's existing uiString/resource pattern) a few hours after this PR opened and is already on main. Might be worth closing this one as a duplicate.

Separately: the reason the coverage gate broke every unrelated open PR in the first place (not just this fix's own scope) is that Tools/i18n_audit.py --ci currently audits the whole merged tree rather than diffing against base_ref, so any regression on main — even a since-fixed one — keeps failing PRs that never touched the offending file until they get a fresh push. Opened #524 to restore the diff-scoped behavior so this class of issue is self-contained to whoever causes it.

@kavemang kavemang closed this Jul 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants