Localize the Android 9.0.1 changelog title - #509
Closed
kavemang wants to merge 1 commit into
Closed
Conversation
kavemang
marked this pull request as ready for review
July 16, 2026 08:02
This was referenced Jul 16, 2026
|
This looks superseded — #514 landed the identical fix (same literal, same extraction into Separately: the reason the coverage gate broke every unrelated open PR in the first place (not just this fix's own scope) is that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
uiString.Why
The 9.0.1 release added this title as a hardcoded Kotlin literal on
main. The i18n Coverage workflow audits the full merged tree, so that baseline violation caused every pull request to fail even when its diff was unrelated.This removes the hardcoded literal and restores a clean i18n baseline without adding the unrelated fix to each affected pull request.
Validation
python3 Tools/i18n_audit.py --ci upstream/main./gradlew :app:compileFullDebugKotlin :app:testFullDebugUnitTest --tests com.noop.ui.GermanLocalizationTestgit diff --check