build: fix line reporting for no-empty-lines-between-requires lint rule - #14320
Merged
kgryte merged 1 commit intoAug 16, 2026
Merged
Conversation
Previously the rule reported errors with `node: null` and a synthetic
location pointing at the blank lines between require statements. Since
blank lines have no code, `eslint-disable-line` comments could not
target them, making per-line suppression impossible.
Change `context.report()` to use the current require node (`currNode`)
so the error is reported on the first require statement after the empty
lines. Users can now append
`// eslint-disable-line stdlib/no-empty-lines-between-requires`
to suppress the rule on a targeted basis.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
- task: lint_filenames
status: passed
- task: lint_editorconfig
status: passed
- task: lint_markdown_pkg_readmes
status: na
- task: lint_markdown_docs
status: na
- task: lint_markdown
status: na
- task: lint_package_json
status: na
- task: lint_repl_help
status: na
- task: lint_javascript_src
status: passed
- task: lint_javascript_cli
status: na
- task: lint_javascript_examples
status: na
- task: lint_javascript_tests
status: passed
- task: lint_javascript_benchmarks
status: na
- task: lint_python
status: na
- task: lint_r
status: na
- task: lint_c_src
status: na
- task: lint_c_examples
status: na
- task: lint_c_benchmarks
status: na
- task: lint_c_tests_fixtures
status: na
- task: lint_shell
status: na
- task: lint_typescript_declarations
status: passed
- task: lint_typescript_tests
status: na
- task: lint_license_headers
status: passed
---
no-empty-lines-between-requires error on the require lineno-empty-lines-between-requires error on the require line
Planeshifter
marked this pull request as ready for review
August 16, 2026 04:41
kgryte
approved these changes
Aug 16, 2026
no-empty-lines-between-requires error on the require lineno-empty-lines-between-requires lint rule
kgryte
deleted the
philipp/fix-no-empty-lines-between-requires-line-location
branch
August 16, 2026 06:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves stdlib-js/metr-issue-tracker#153.
Description
This pull request:
no-empty-lines-between-requiresESLint rule to report errors on the first require statement after the empty lines, rather than on the empty lines themselves// eslint-disable-line stdlib/no-empty-lines-between-requiresPreviously, the rule reported errors with
node: nulland a syntheticlocpointing at the blank lines between require statements. Since blank lines contain no code,// eslint-disable-linecomments could not be placed there, making per-line suppression impossible. The only workaround was disabling the rule for the entire file.Related Issues
This pull request has the following related issues:
no-empty-lines-between-requiresrule metr-issue-tracker#153Questions
No.
Other
The key change in
context.report():By reporting on
currNode(the require statement after the gap), ESLint uses that node's location. Users can now append// eslint-disable-line stdlib/no-empty-lines-between-requiresto suppress the rule on that specific line.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was written primarily by Claude Code under my direction.
@stdlib-js/reviewers