Skip to content

build: fix line reporting for no-empty-lines-between-requires lint rule #14320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kgryte merged 1 commit into from
Aug 16, 2026
+39 −25
Merged

build: fix line reporting for no-empty-lines-between-requires lint rule #14320

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 1 addition & 13 deletions lib/node_modules/@stdlib/_tools/eslint/rules/no-empty-lines-between-requires/lib/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,21 +165,9 @@ function main( context ) {
* @param {ASTNode} currNode - current require node
*/
function report( prevNode, currNode ) {
var loc = {
'start': {
'line': prevNode.loc.end.line + 1,
'column': 0
},
'end': {
'line': currNode.loc.start.line,
'column': 0
}
};

context.report({
'node': null,
'node': currNode,
'message': 'Unexpected empty line between require statements.',
'loc': loc,
'fix': fix
});

Expand Down
36 changes: 24 additions & 12 deletions ...ules/@stdlib/_tools/eslint/rules/no-empty-lines-between-requires/test/fixtures/invalid.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,8 @@ var test = {
'errors': [
{
'message': 'Unexpected empty line between require statements.',
'type': null
'type': 'VariableDeclaration',
'line': 7
}
],
'output': [
Expand Down Expand Up @@ -63,7 +64,8 @@ test = {
'errors': [
{
'message': 'Unexpected empty line between require statements.',
'type': null
'type': 'VariableDeclaration',
'line': 8
}
],
'output': [
Expand Down Expand Up @@ -92,7 +94,8 @@ test = {
'errors': [
{
'message': 'Unexpected empty line between require statements.',
'type': null
'type': 'VariableDeclaration',
'line': 8
}
],
'output': [
Expand Down Expand Up @@ -121,7 +124,8 @@ test = {
'errors': [
{
'message': 'Unexpected empty line between require statements.',
'type': null
'type': 'VariableDeclaration',
'line': 7
}
],
'output': [
Expand Down Expand Up @@ -151,11 +155,13 @@ test = {
'errors': [
{
'message': 'Unexpected empty line between require statements.',
'type': null
'type': 'VariableDeclaration',
'line': 7
},
{
'message': 'Unexpected empty line between require statements.',
'type': null
'type': 'VariableDeclaration',
'line': 9
}
],
'output': [
Expand Down Expand Up @@ -185,7 +191,8 @@ test = {
'errors': [
{
'message': 'Unexpected empty line between require statements.',
'type': null
'type': 'VariableDeclaration',
'line': 8
}
],
'output': [
Expand Down Expand Up @@ -214,7 +221,8 @@ test = {
'errors': [
{
'message': 'Unexpected empty line between require statements.',
'type': null
'type': 'VariableDeclaration',
'line': 7
}
],
'output': [
Expand All @@ -241,7 +249,8 @@ test = {
'errors': [
{
'message': 'Unexpected empty line between require statements.',
'type': null
'type': 'VariableDeclaration',
'line': 6
}
],
'output': [
Expand All @@ -268,7 +277,8 @@ test = {
'errors': [
{
'message': 'Unexpected empty line between require statements.',
'type': null
'type': 'VariableDeclaration',
'line': 7
}
],
'output': [
Expand Down Expand Up @@ -298,7 +308,8 @@ test = {
'errors': [
{
'message': 'Unexpected empty line between require statements.',
'type': null
'type': 'VariableDeclaration',
'line': 7
}
],
'output': [
Expand Down Expand Up @@ -330,7 +341,8 @@ test = {
'errors': [
{
'message': 'Unexpected empty line between require statements.',
'type': null
'type': 'VariableDeclaration',
'line': 9
}
],
'output': [
Expand Down
14 changes: 14 additions & 0 deletions ...odules/@stdlib/_tools/eslint/rules/no-empty-lines-between-requires/test/fixtures/valid.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,6 +172,20 @@ test = {
};
valid.push( test );

// Inline disable comment suppresses the rule for a specific require:
test = {
'code': [
'\'use strict\';',
'',
'// MODULES //',
'',
'var tape = require( \'tape\' );',
'',
'var isnan = require( \'@stdlib/math/base/assert/is-nan\' ); // eslint-disable-line no-empty-lines-between-requires'
].join( '\n' )
};
valid.push( test );


// EXPORTS //

Expand Down