runtime: separate broker activity from persistence - #70
Merged
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f1241184e6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
sumitake
force-pushed
the
dev/codex/dispatcher-idle-grace-status
branch
2 times, most recently
from
July 28, 2026 07:55
c7c1406 to
d6affee
Compare
21 tasks
sumitake
force-pushed
the
dev/codex/dispatcher-idle-grace-status
branch
from
July 28, 2026 08:40
d6affee to
d075e61
Compare
sumitake
force-pushed
the
dev/codex/dispatcher-idle-grace-status
branch
from
July 28, 2026 09:26
d075e61 to
1f2fb48
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
agent-collab4.5.2.launchctl printtranscript: exact top-level properties plus structured conditional
event-trigger evidence, with malformed, incomplete, or ambiguous shapes
failing closed.
persistent_process=true|false|nullindependently from the boundedpoint-in-time observation
process_idle=true|false|null; null meansunproven/unmeasured, never false.
without
process_idle.and prove a failed stage restores the exact baseline selector.
https://github.com/sumitake/agent-collab-workspace/pull/2438.
Neither PR is release or activation evidence by itself.
Exact paired artifact
12b4c4abf47d9e78df45401c7f4d85187d453a7c1f2fb48085228b4eccded389b612c7182c542aee5e9d4ba49e0a08b9180ae48f65ac64af18c3838e203e268eca0346bcead10e93b21e97a3b34686ebcae34e444bbd6c5f8278e647cc41e7bb75968af1f5ac94706c87b712e72afe33bfb7d2f4f00d7d63ea8119e1d1599da5b0ead944f7a436a23175d5a3e15167c6ec0bfb2274fb1b5414e283969662d83d464991713c0ad5f482773658bfa2f9fcThe artifact contains both complete binary diffs with repository-specific path
prefixes and binds every base, head, component size, and component digest.
Boundary declaration
absolute path, retired package tree, downloader, or post-install hook is
included.
provider-specific plugin.
Generated and release surfaces
changelog.d/fragment present; generatedCHANGELOG.mdunchanged.
Verification
python3 -B scripts/check_release_consistency.py.python3 -B scripts/build-changelog.py --dry-run.git diff --check.Exact implementation review
agent-collab-paired-dispatcher-client-exact-grok-review-20260728-54.5.1+codex.dev.04faa73aef4c.b4e78e9dac3f, invoked withpython3 -Bgrok/governance; reviewerxai/grok-4.5; authorityread_onlystatus=ok, return code 0, raw valid JSONLec0bfb2274fb1b5414e283969662d83d464991713c0ad5f482773658bfa2f9fcseverity=None; no blocking lifecycle, race, parser, tri-state,compatibility, rollback, or documentation defect
active=true,dispatcher_ready=true,rollback available, selected lane31 artifact/manifest unchanged
Review and post-condition
Tier 3: this changes the public runtime client's lifecycle/status contract.
Merge workspace PR #2438 first, then this PR. After a separately governed
runtime build and activation, run serial provider-free boundary canaries before
clearing the managed-provider freeze. Retained lane 30 and immutable lane-31
rollback bytes remain untouched.
Compliance trace
author: codex
standing_directives: read and followed public AGENTS.md, docs/public-governance.md, public-source boundaries, generated parity, fragment-only changelog, signed-commit, and exact-head validation requirements
tier: 3
cross_check: PROCEED - xai/grok-4.5 reviewed exact paired artifact ec0bfb2274fb1b5414e283969662d83d464991713c0ad5f482773658bfa2f9fc via agent-collab-paired-dispatcher-client-exact-grok-review-20260728-5 with typed status ok and severity None; artifact binds public 1f2fb48 and workspace cc41e7bb75968af1f5ac94706c87b712e72afe33
post_condition: merge workspace PR #2438 first and this public client PR second; do not release or activate until governed runtime build evidence exists, then run serial provider-free boundary canaries before clearing the provider freeze
mcp_coverage_gap: NONE
contributor_rights: OWNER-AUTHORED
operator_reserved: no