fix: accept offline_access OAuth scope for MCP refresh clients#2630
Open
rohanpatel2002 wants to merge 1 commit into
Open
fix: accept offline_access OAuth scope for MCP refresh clients#2630rohanpatel2002 wants to merge 1 commit into
rohanpatel2002 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
The OAuth 2.1 authorization server already issues refresh tokens on the authorization-code grant and supports the
refresh_tokengrant. However,offline_accessis not in the supported scope allowlist (SupportedOAuthScopes), so:GET /oauth/authorize?...&scope=openid%20offline_accessfails witherror=invalid_request/unsupported scope: offline_access/.well-known/oauth-authorization-serveradvertisesscopes_supported: ["openid","profile","email","phone"]withoutoffline_accessMCP clients (Copilot Studio, ChatGPT, and similar) often require
offline_accessto be advertised and granted before they will use refresh tokens. Without it, they hold unused refresh tokens, access tokens expire after ~1 hour, and users are forced to re-authenticate.Fixes #2628
What is the new behavior?
offline_accessis added toSupportedOAuthScopes(accept-and-ignore). Because authorize validation and discovery metadata both use that shared list:offline_accesssucceedoffline_accessinscopes_supportedNo change to token issuance: refresh tokens were already issued unconditionally when configured.
Additional context
Single-source change in
internal/models/oauth_scope.go, with a unit test assertingIsSupportedScope("offline_access"). Happy to adjust if maintainers prefer a different approach. Thank you for reviewing.