Skip to content

fix: accept offline_access OAuth scope for MCP refresh clients #2630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rohanpatel2002 wants to merge 1 commit into
base: master
Choose a base branch
from
+11 −4
Open

fix: accept offline_access OAuth scope for MCP refresh clients #2630

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions internal/models/oauth_scope.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,11 @@ import "strings"

// OAuth/OIDC scope constants
const (
ScopeOpenID = "openid"
ScopeEmail = "email"
ScopeProfile = "profile"
ScopePhone = "phone"
ScopeOpenID = "openid"
ScopeEmail = "email"
ScopeProfile = "profile"
ScopePhone = "phone"
ScopeOfflineAccess = "offline_access"
)

// SupportedOAuthScopes defines all OAuth/OIDC scopes supported by the server
Expand All @@ -16,6 +17,7 @@ var SupportedOAuthScopes = []string{
ScopeProfile,
ScopeEmail,
ScopePhone,
ScopeOfflineAccess,
}

// IsSupportedScope checks if a scope is in the supported scopes list
Expand Down
5 changes: 5 additions & 0 deletions internal/models/oauth_scope_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,6 +224,11 @@ func TestIsSupportedScope(t *testing.T) {
scope: ScopePhone,
expected: true,
},
{
name: "offline_access scope is supported",
scope: ScopeOfflineAccess,
expected: true,
},
{
name: "unsupported scope address",
scope: "address",
Expand Down