chore: move scroll restoration and focus reset out of client.js - #16980
chore: move scroll restoration and focus reset out of client.js#16980Nic-Polumeyv wants to merge 2 commits into
Conversation
|
Install the latest version of pnpm add https://pkg.svelte.dev/@sveltejs/kit/c/01f7ffb627052025412c596a1ca1ebb0cf40600cOpen in |
|
fb4651b to
4386cd6
Compare
4386cd6 to
2b735ad
Compare
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (6)
Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📝 WalkthroughWalkthroughFocus, hash lookup, and scroll management move from ChangesClient navigation focus and scroll handling
Estimated code review effort: 3 (Moderate) | ~25 minutes Merge Risk: ⚪ Minimal · up to This PR reorganizes existing focus-reset and scroll-restoration behavior without changing its intended runtime behavior. The change is localized and merge-ready after normal checks, with no actionable merge-blocking risk remaining. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Warning Some tools did not complete. Review the errors below. 🔧 ESLint
ESLint install failed: private package registry requires authentication. Disable ESLint in CodeRabbit settings or use public packages. Comment |
Scroll restoration and focus reset live in
client.jsbut read none of its state. This moves them, unchanged, into their own module, the shapesnapshots.jstook in #16685.Summary by CodeRabbit