Carry the test target at the app's version too - #58
Merged
Conversation
release-tag.yml requires one distinct MARKETING_VERSION across the whole project file, so the UI test target arriving at Xcode's default 1.0 was enough to open the next release with "MARKETING_VERSION is not the same everywhere: 1.0 1.1.0". It would not have stopped anything — Xcode Cloud is already archiving by the time that runs — which is the bad kind of failure: a red check on the release tag, for a bundle nobody installs, found while looking at something else. Carried rather than exempted. The check is a grep over every configuration in the file, and its value is that it needs to know nothing about targets; teaching it which ones to believe costs more than one line per bump.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found while checking what a
v1.1.0tag would do now that the Xcode Cloud action and the App Store Connect version record are in place.release-tag.ymlgreps everyMARKETING_VERSIONinproject.pbxprojand requires one distinct value. The UI test target arrived with Xcode's default:So the tag would have opened with
MARKETING_VERSION is not the same everywhere: 1.0 1.1.0. It would not have blocked the release — Xcode Cloud is already archiving by the time that workflow runs — which is the worse shape: a red check on the release tag, for a bundle nobody installs.Carried rather than exempted. The check's value is that it knows nothing about targets; teaching a grep which ones to believe costs more than one line per bump. The
releaseskill now says so, since it previously said "all four configurations" and there are six.Verified:
xcodebuild -target TortoiseBlocksUITests -showBuildSettingsresolvesMARKETING_VERSION = 1.1.0, and the simulated check now yields a single value.