Skip to content

Carry the test target at the app's version too #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
temoki merged 1 commit into from
Aug 25, 2026
Merged

Carry the test target at the app's version too #58

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion .claude/skills/release/SKILL.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,7 +231,14 @@ iOS to notice if you don't.
What *is* unlinked is the tag and the version it ships: nothing makes
`v0.2.0` and `MARKETING_VERSION` agree, and a mismatch uploads the old
version silently. `release-tag.yml` compares them (and catches app/extension
drift, since it requires one distinct value across all four configurations).
drift, since it requires one distinct value across every configuration in the
project). **That is every configuration, including targets that ship
nothing**: adding the UI test target put a fifth and sixth `MARKETING_VERSION`
in the file at Xcode's default `1.0`, and the next tag would have opened with
`MARKETING_VERSION is not the same everywhere` — a red check on the release,
for a test bundle nobody installs. It is carried at the app's version rather
than exempted, because the alternative is teaching a `grep` which targets to
believe.
It cannot block the release — Xcode Cloud is already archiving — it only
makes the mistake loud while there is still a build to cancel. A suffix after
`-` is stripped before comparing: a marketing version is dotted numbers, a
Expand Down
4 changes: 2 additions & 2 deletions TortoiseBlocks.xcodeproj/project.pbxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -350,7 +350,7 @@
GCC_WARN_UNINITIALIZED_AUTOS = YES_AGGRESSIVE;
GENERATE_INFOPLIST_FILE = YES;
IPHONEOS_DEPLOYMENT_TARGET = 26.5;
MARKETING_VERSION = 1.0;
MARKETING_VERSION = 1.1.0;
PRODUCT_BUNDLE_IDENTIFIER = space.hiraku.tortoiseblocks.uitests;
PRODUCT_NAME = "$(TARGET_NAME)";
SDKROOT = auto;
Expand Down Expand Up @@ -381,7 +381,7 @@
GCC_WARN_UNINITIALIZED_AUTOS = YES_AGGRESSIVE;
GENERATE_INFOPLIST_FILE = YES;
IPHONEOS_DEPLOYMENT_TARGET = 26.5;
MARKETING_VERSION = 1.0;
MARKETING_VERSION = 1.1.0;
PRODUCT_BUNDLE_IDENTIFIER = space.hiraku.tortoiseblocks.uitests;
PRODUCT_NAME = "$(TARGET_NAME)";
SDKROOT = auto;
Expand Down