test: assert the real app renders instead of a deleted starter skeleton - #14
Open
PouyanJay wants to merge 1 commit into
Open
test: assert the real app renders instead of a deleted starter skeleton#14PouyanJay wants to merge 1 commit into
PouyanJay wants to merge 1 commit into
Conversation
The suite asserted the vinext starter's loading skeleton — a preview directory, a react-loading-skeleton dependency and a "Starter Project" title, none of which have existed since Anatomy Atelier was built on top of the template. So `npm test` failed on main, and the repo had no working automated check of any kind. Replaced with assertions against what the worker actually serves: the page identity and social metadata, the organ library and all nine organs, the server-rendered content of the default specimen, the viewer mount, and the screen-reader equivalent of the hotspot dots — that last one being worth guarding, since the dots themselves live inside a canvas and the list is the only thing assistive tech can reach. The starter check is kept, but inverted: the test now fails if any trace of the template reappears in the output. Fixes thebuggeddev#11
|
@PouyanJay is attempting to deploy a commit to the thebuggeddev-9222's projects Team on Vercel. A member of the Team first needs to authorize it. |
This was referenced Aug 6, 2026
PouyanJay
force-pushed
the
fix/11-test-suite
branch
from
August 7, 2026 07:46
9ca3bfc to
eab263a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11.
npm testfailed onmain, so the repo had no working automated check at all. The suite was still asserting the vinext starter's loading skeleton — aapp/_sites-preview/directory, areact-loading-skeletondependency and a"Starter Project"title — none of which have existed since Anatomy Atelier was built on the template.What it asserts now
Six tests against what the built worker actually serves:
text/htmlog:image, apple touch iconthree-mount,viewer-tools, and thehotspot-indexlist. That last one is worth guarding: the hotspot dots live inside the canvas, so this list is the only thing assistive tech can reach.Verification
Full
npm test(build + test) passes.Also verified against #9. Assertions were deliberately chosen to hold on both
mainand the viewer branch — I merged #9 into a scratch branch and re-ran the suite, 6/6. So these two can merge in either order without conflict.Should go in before #12, since a dependency bump needs a working test before it can be trusted.