Skip to content

Capsule flavor - #735

Merged
Gauravtalreja1 merged 4 commits into
theforeman:masterfrom
arvind4501:capsule-flavor
Aug 14, 2026
Merged

Capsule flavor#735
Gauravtalreja1 merged 4 commits into
theforeman:masterfrom
arvind4501:capsule-flavor

Conversation

@arvind4501

Copy link
Copy Markdown
Contributor

Why are you introducing these changes? (Problem description, related links)

What are the changes introduced in this pull request?

How to test this pull request

Steps to reproduce:

Checklist

  • Tests added/updated (if applicable)
  • Documentation updated (if applicable)

@arvind4501
arvind4501 marked this pull request as draft August 10, 2026 06:24
@arvind4501
arvind4501 force-pushed the capsule-flavor branch 4 times, most recently from 85ba423 to 2a773f5 Compare August 10, 2026 12:38

@jeremylenz jeremylenz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @arvind4501

Looking forward to this!

- content/ansible
- content/container
- content/rpm
- remote-execution

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that templates and registration features are available, Capsule flavor should have them 🙂

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure we can add those, but in SAT-47662 these are not part of the enabled features by default. having said that i think we can surely enable those as they were in foreman-installer.
@ekohl what do you think about enabling these features by default in capsule deployment?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar to #726 I think we should first aim at parity with the existing install where possible. I'll modify the downstream issue accordingly.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar to #726 I think we should first aim at parity with the existing install where possible

does that mean, we should add those(templates, registration) feature in capsule defaults?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

@evgeni evgeni mentioned this pull request Aug 12, 2026
2 tasks

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you put this under verndor_overrides/satellite, you only need one cp command in the setup. I've originally meant the satellite here as the product, not the software.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or if we decide to keep it separate we might need packaging change as similar to satellite flavor?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need packaging change both ways, i opted what evgeni suggested to put overrides under verndor_overrides/satellite.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It needs a packaging change downstream either way (which Arvind already has prepared).

The files here are only for CI.

@arvind4501
arvind4501 marked this pull request as ready for review August 13, 2026 09:34
Comment thread .github/workflows/test.yml

@evgeni evgeni left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one tests nitpick, but ack either way

@Gauravtalreja1 Gauravtalreja1 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, tested with foremanctl-3.0.0.develop-4.20260814050952506859.pr735.207.g06e3c13.el10.noarch 🍏

Scenarios tested:

  • Satellite + Capsule deployment with vendor overrides -> works
  • Auth bundle workflow (generate, fetch/copy, deploy-proxy) -> works
  • Health check passes
  • Pulp API, services, mirror mode, RHSM URL -> correct
  • Feature listing correctly hides/shows enabled features
  • Capsule uses auth bundle certs, no CA key present -> works
  • Capsule registered on Satellite correctly, and content sync works
  • No regressions on foreman-proxy-content flavor

@Gauravtalreja1
Gauravtalreja1 merged commit 8ccbaa2 into theforeman:master Aug 14, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants