Add trailing newline to six settings request files - #185
Open
xmap wants to merge 1 commit into
Open
Conversation
autosave skips a final .req line that is not newline-terminated, so the last PV in each of these files has never been saved or restored. At 2BMB, FlipStitch is absent from all 587 save files in the autosave directory, including dated backups from 2021, while its neighbours are in every one. Verified on a scratch IOC (base 7.0.8, autosave R5-11): with a deliberately unterminated .req, autosave saved every listed PV except the last one, and adding the newline restored it. Affected last entries: FlipStitch, CbPluginPVPrefix, Filters, Pause, ProgramPSO, StabilizationTime. Fixes tomography#184
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
autosave skips a final
.reqline that is not newline-terminated, so the last PV listed in each of these six files is never saved or restored.Verified on a scratch IOC (base 7.0.8, autosave R5-11): with a deliberately unterminated
.req, autosave saved every listed PV except the last, and adding the newline restored it. At 2BMB,FlipStitchis absent from all 587 save files in the autosave directory, including dated backups from 2021, while its neighbours appear in every one.Affected last entries:
tomoScan_settings.reqFlipStitch(base, so every beamline)tomoScan_2BM_settings.reqCbPluginPVPrefixtomoScan_2ID_settings.reqFilterstomoScan_32ID_settings.reqPausetomoScan_PSO_settings.reqProgramPSOtomoScan_step_settings.reqStabilizationTimeSix added newline characters, no other change. Closes #184, and explains the
FlipStitchanomaly in #182.