Address openid session crashes on invalid input by jonasbardino · Pull Request #592 · ucphhpc/migrid-sync

jonasbardino · 2026-07-15T08:54:36Z

Attempt to address #589 with more robust handling of various errors and especially the input validation ones. Show a generic error page and only write log warnings rather than errors in that case.
Check the openid library could in fact decode user query to a request before using the result in order to avoid some NoneType object attribute errors when it couldn't.

Some generic lint fixes and polish of error messages to properly show support email.

especially the input validation ones. Show a generic error page and only write log warnings rather than errors in that case. Check the openid library could in fact decode user query to a request before using the result in order to avoid some NoneType object attribute errors when it couldn't.

Removed unused parent openid module import and left it to the openid.x module imports to fail hard if missing.

…o avoid redundancy.

jonasbardino · 2026-07-15T09:39:42Z

~~Hmm, not sure why the linting currently fails with just the very unhelpful Error: message. Neither pylint nor ruff complain when running locally.~~

UPDATE: the above turned out to be my browser settings preventing full page load and now I can see that it's just one of the old lint errors covered in #338.

@Martin-Rehr

attribute (thanks @Martin-Rehr).

Martin-Rehr

Approved with a few comments

…rict and avoid greedy swallowing of ValueError triggered outside the actual validation. This is follow-up to #592 in relation to the post-merge discussion there. Add 'better safe than sorry' validation of all query components. Switch `invalid_argument` helper to reusing `InputException` to let exception handlers focus on that kind only. Avoid potential clashes with 2nd (key, val)-iterator in same scope.

…rict after PR592 (#634) * Rework the built-in openid 2.0 service input validation to be more strict and avoid greedy swallowing of ValueError triggered outside the actual validation. This is follow-up to #592 in relation to the post-merge discussion there. Add 'better safe than sorry' validation of all query components. Switch `invalid_argument` helper to reusing `InputException` to let exception handlers focus on that kind only. Avoid potential clashes with 2nd (key, val)-iterator in same scope.

…hitting openid message objects that it doesn't know what to do about. Force to string to make it succeed.

jonasbardino added 2 commits July 15, 2026 10:40

Various lint fixes from ruff.

87d1e00

Removed unused parent openid module import and left it to the openid.x module imports to fail hard if missing.

jonasbardino self-assigned this Jul 15, 2026

jonasbardino added the bug Something isn't working label Jul 15, 2026

jonasbardino added this to the OpenID Connect Support milestone Jul 15, 2026

jonasbardino linked an issue Jul 15, 2026 that may be closed by this pull request

OpenID service session crashes on invalid GET request #589

Closed

Escape the support email to let it show properly. Polish text a bit t…

ecc6875

…o avoid redundancy.

jonasbardino added the battle-tested Code was tested to be fully functional in line with project code guidelines. label Jul 15, 2026

jonasbardino marked this pull request as ready for review July 15, 2026 09:41

jonasbardino requested a review from a team July 15, 2026 09:41