fix(shell): add aria-label to theme toggle button#1
Open
lourincedaging0-commits wants to merge 1 commit into
Open
fix(shell): add aria-label to theme toggle button#1lourincedaging0-commits wants to merge 1 commit into
lourincedaging0-commits wants to merge 1 commit into
Conversation
Every other icon-only button in the app (ArtifactDrawer, ChatView, PendingView) exposes an accessible name via aria-label; the theme toggle relied on title alone, which isn't reliably announced by screen readers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Shell.tsxwas the only icon-only button in the app relying solely ontitlefor its accessible name. Every other icon-only button (ArtifactDrawer,ChatView,PendingView) already usesaria-label.titlealone isn't reliably announced by screen readers.aria-label="Toggle theme"alongside the existingtitle, matching the established pattern.Test plan
npx tsc --noEmit— cleannpx vitest run— 102/102 passing (added an assertion inShell.test.tsxthat the button is queryable viagetByRole('button', { name: /toggle theme/i }))